Custom integration test for issue #30

Author: fubar-coder

test/FubarDev.FtpServer.Tests/FtpServerFixture.cs

@@ -13,17 +13,20 @@
 namespace FubarDev.FtpServer.Tests
 {
     /// <summary>
-    /// Fixture that initializes an FTP server
+    /// Fixture that initializes an FTP server.
     /// </summary>
     public class FtpServerFixture : IAsyncLifetime
     {
-        private readonly IServiceProvider _serviceProvider;
+        private ServiceProvider? _serviceProvider;
         private IFtpServer? _server;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="FtpServerFixture"/> class.
+        /// Gets the FTP server.
         /// </summary>
-        public FtpServerFixture()
+        public IFtpServer Server => _server ?? throw new InvalidOperationException();
+
+        /// <inheritdoc />
+        public Task InitializeAsync()
         {
             var services = new ServiceCollection()
                .AddLogging(
@@ -36,33 +39,50 @@ public FtpServerFixture()
                         lb.AddFilter("FubarDev.FtpServer", LogLevel.Trace);
                     })
                .AddFtpServer(
-                    opt => opt.EnableAnonymousAuthentication()
-                       .UseSingleRoot()
-                       .UseInMemoryFileSystem())
-               .Configure<FtpServerOptions>(opt =>
-                {
-                    // IPv4 localhost
-                    opt.ServerAddress = "127.0.0.1";
-
-                    // Dynamic port
-                    opt.Port = 0;
-                });
+                    opt => Configure(opt));
+            services = Configure(services);
             _serviceProvider = services.BuildServiceProvider(true);
+            _server = _serviceProvider.GetRequiredService<IFtpServer>();
+            return _server.StartAsync(default);
         }
 
-        public IFtpServer Server => _server ?? throw new InvalidOperationException();
-
         /// <inheritdoc />
-        public Task InitializeAsync()
+        public async Task DisposeAsync()
         {
-            _server = _serviceProvider.GetRequiredService<IFtpServer>();
-            return _server.StartAsync(default);
+            await Server.StopAsync(default).ConfigureAwait(false);
+            _serviceProvider?.Dispose();
         }
 
-        /// <inheritdoc />
-        public Task DisposeAsync()
+        /// <summary>
+        /// Basic FTP server configuration for the basic configuration through <see cref="Configure(IFtpServerBuilder)"/>.
+        /// </summary>
+        /// <param name="services">The service collection.</param>
+        /// <returns>The modified service collection.</returns>
+        protected virtual IServiceCollection Configure(IServiceCollection services)
+        {
+            return services
+               .Configure<FtpServerOptions>(
+                    opt =>
+                    {
+                        // IPv4 localhost
+                        opt.ServerAddress = "127.0.0.1";
+
+                        // Dynamic port
+                        opt.Port = 0;
+                    });
+        }
+
+        /// <summary>
+        /// Basic configuration using the FTP server builder.
+        /// </summary>
+        /// <param name="builder">The FTP server builder used for the configuration.</param>
+        /// <returns>The modified FTP server builder.</returns>
+        protected virtual IFtpServerBuilder Configure(IFtpServerBuilder builder)
         {
-            return Server.StopAsync(default);
+            return builder
+               .EnableAnonymousAuthentication()
+               .UseSingleRoot()
+               .UseInMemoryFileSystem();
         }
     }
 }

test/FubarDev.FtpServer.Tests/Issues/Issue30CustomFtpUser.cs

@@ -0,0 +1,89 @@
+// <copyright file="Issue30CustomFtpUser.cs" company="Fubar Development Junker">
+// Copyright (c) Fubar Development Junker. All rights reserved.
+// </copyright>
+
+using System.Security.Claims;
+using System.Threading.Tasks;
+
+using FluentFTP;
+
+using FubarDev.FtpServer.AccountManagement;
+
+using Microsoft.Extensions.DependencyInjection;
+
+using Xunit;
+
+namespace FubarDev.FtpServer.Tests.Issues
+{
+    public class Issue30CustomFtpUser : IClassFixture<Issue30CustomFtpUser.Issue30FtpServerFixture>
+    {
+        private readonly IFtpServer _server;
+
+        public Issue30CustomFtpUser(Issue30FtpServerFixture ftpServerFixture)
+        {
+            _server = ftpServerFixture.Server;
+        }
+
+        [Fact]
+        public async Task LoginSucceedsWithTester()
+        {
+            using var client = new FtpClient("127.0.0.1", _server.Port, "tester", "test");
+            await client.ConnectAsync();
+        }
+
+        [Fact]
+        public async Task LoginFailsWithWrongUserName()
+        {
+            using var client = new FtpClient("127.0.0.1", _server.Port, "testerX", "test");
+            await Assert.ThrowsAsync<FtpAuthenticationException>(() => client.ConnectAsync())
+               .ConfigureAwait(false);
+        }
+
+        [Fact]
+        public async Task LoginFailsWithWrongPassword()
+        {
+            using var client = new FtpClient("127.0.0.1", _server.Port, "tester", "testX");
+            await Assert.ThrowsAsync<FtpAuthenticationException>(() => client.ConnectAsync())
+               .ConfigureAwait(false);
+        }
+
+        /// <summary>
+        /// Custom configuration of the FTP server.
+        /// </summary>
+        public class Issue30FtpServerFixture : FtpServerFixture
+        {
+            /// <inheritdoc />
+            protected override IFtpServerBuilder Configure(IFtpServerBuilder builder)
+            {
+                return builder
+                   .UseSingleRoot()
+                   .UseInMemoryFileSystem();
+            }
+
+            /// <inheritdoc />
+            protected override IServiceCollection Configure(IServiceCollection services)
+            {
+                return base.Configure(services)
+                   .AddSingleton<IMembershipProvider, CustomMembershipProvider>();
+            }
+        }
+
+        private class CustomMembershipProvider : IMembershipProvider
+        {
+            /// <inheritdoc />
+            public Task<MemberValidationResult> ValidateUserAsync(string username, string password)
+            {
+                if (username == "tester" && password == "test")
+                {
+                    var identity = new ClaimsIdentity();
+                    return Task.FromResult(
+                        new MemberValidationResult(
+                            MemberValidationStatus.AuthenticatedUser,
+                            new ClaimsPrincipal(identity)));
+                }
+
+                return Task.FromResult(new MemberValidationResult(MemberValidationStatus.InvalidLogin));
+            }
+        }
+    }
+}