[Bug]: Write Virtual Discharge Error

[wilson-ricks]

Bug description

The line dfVirtualDischarge.AnnualSum .= virtual_discharge * inputs["omega"] in write_virtual_discharge.jl always throws an ArgumentError.

Simple suggested solution: replace the relevant line with dfVirtualDischarge.AnnualSum = virtual_discharge * inputs["omega"]

Environment and Version

Linux, Julia 1.6.1, Main branch

Relevant error messages

Additional context

No response

[sambuddhac]

Thanks @wilson-ricks . Did you check with Julia 1.9.x+ versions. I am not sure how many folks are still running with Julia 1.6. @lbonaldo do you have any thoughts on this?

[lbonaldo]

Thank you @wilson-ricks for spotting this!

By looking at the implementation of

1. dfVirtualDischarge.AnnualSum .= virtual_discharge * inputs["omega"]
2. dfVirtualDischarge.AnnualSum = virtual_discharge * inputs["omega"]

the main difference is that 1. calls Base.getproperty(dfVirtualDischarge, :AnnualSum) (but the column doesn't exist yet, and therefore the error), while 2. uses Base.setproperty(dfVirtualDischarge, :AnnualSum, virtual_discharge * inputs["omega"]) (no error, as setproperty creates a new column to store the new values).

In Julia > 1.6, 1. was changed to use Base.dotgetproperty instead of Base.getproperty which is why we don't see the error when running GenX with Julia 1.7+.

Reference: JuliaLang/julia#36741

[lbonaldo]

Thank you @wilson-ricks for opening this issue. I'm closing it as completed.