Prevent out of quota 429 responses from report -> error looping. (#90)

Co-authored-by: Jon Masukawa <jmasukawa@google.com>

Author: jmasukawa

stackdriver-errors.js

@@ -179,6 +179,15 @@ function sendErrorPayload(url, payload) {
         var code = xhr.status;
         if (code >= 200 && code < 300) {
           resolve({message: payload.message});
+        } else if (code === 429) {
+          // HTTP 429 responses are returned by Stackdriver when API quota
+          // is exceeded. We should not try to reject these as unhandled errors
+          // or we may cause an infinite loop with 'reportUncaughtExceptions'.
+          reject(
+            {
+              message: 'quota or rate limiting error on stackdriver report',
+              name: 'Http429FakeError',
+            });
         } else {
           var condition = code ? code + ' http response'  : 'network error';
           reject(new Error(condition + ' on stackdriver report'));

test/test.js

@@ -249,6 +249,24 @@ describe('Reporting errors', function() {
           expect(err.message).to.equal('503 http response on stackdriver report');
         });
       });
+
+      it('should not handle quota exceeded error responses', function() {
+        requestHandler = function(req) {
+          // HTTP 429 returned from Stackdriver after reaching reporting quota.
+          req.respond(429, {'Content-Type': 'text/plain'}, '');
+        };
+        errorHandler.start({key: 'key', projectId: 'projectId'});
+        var message = 'News that will be rejected on send';
+        return errorHandler.report(message).then(function() {
+          throw new Error('unexpected fulfilled report');
+        }, function(fakeErr) {
+          expectRequestWithMessage(message);
+          // We don't expect an Error to be returned in this case.
+          expect(fakeErr.name).to.equal('Http429FakeError');
+          expect(fakeErr.message).to.equal(
+            'quota or rate limiting error on stackdriver report');
+        });
+      });
     });
   });