Add style lint rules and fix code (#60)

Based off the Google style guide:

    https://google.github.io/styleguide/jsguide.html

As encoded in the eslint-config-google package, with some tweaks
suitable for an ES5 only project.

For now, the max-len rule has not been added.

Author: bz2

.eslintrc.json

@@ -12,14 +12,40 @@
     "Promise": false
   },
   "rules": {
+    "array-bracket-spacing": "error",
     "block-scoped-var": "error",
+    "brace-style": "error",
+    "camelcase": ["error", {"properties": "never"}],
+    "comma-dangle": ["error", "always-multiline"],
+    "comma-spacing": "error",
     "complexity": ["error", 15],
+    "computed-property-spacing": "error",
     "curly": "error",
     "eqeqeq": ["error", "smart"],
-    "linebreak-style": ["error", "unix"],
+    "eol-last": "error",
+    "func-call-spacing": "error",
+    "indent": ["error", 2],
+    "key-spacing": "error",
+    "keyword-spacing": "error",
+    "linebreak-style": "error",
+    "new-cap": "error",
+    "no-array-constructor": "error",
+    "no-multiple-empty-lines": ["error", {"max": 2}],
+    "no-tabs": "error",
+    "no-trailing-spaces": "error",
+    "object-curly-spacing": "error",
+    "padded-blocks": ["error", "never"],
     "quote-props": ["error", "as-needed"],
     "quotes": ["error", "single"],
     "semi": "error",
+    "semi-spacing": "error",
+    "space-before-blocks": "error",
+    "space-before-function-paren": ["error", {
+      "anonymous": "never",
+      "named": "never"
+    }],
+    "spaced-comment": ["error", "always"],
+    "switch-colon-spacing": "error",
     "unicode-bom": ["error", "never"]
   },
   "overrides": [{

demo/demo-angular.js

@@ -4,7 +4,7 @@ angular.module('demoApp', []) // eslint-disable-line no-undef
     var StackdriverErrors = new $window.StackdriverErrorReporter();
     StackdriverErrors.start({
       projectId: '<your-project-id>',
-      key: '<your-api-key>'
+      key: '<your-api-key>',
     });
 
     return function(exception, cause) {

demo/demo.js

@@ -27,7 +27,7 @@ function updateConfig() {
     key: key,
     projectId: projectId,
     service: 'webapp',
-    version: 'demo'
+    version: 'demo',
   });
 }
 
@@ -37,7 +37,7 @@ function loadFromLocalStorage() {
   document.getElementById('input-apikey').value = key;
   document.getElementById('input-projectid').value = projectId;
 
-  if(key && projectId) {
+  if (key && projectId) {
     updateConfig();
   } else {
     // eslint-disable-next-line no-console
@@ -53,12 +53,12 @@ function vanillaCrash() { // eslint-disable-line no-unused-vars
   starUsers();
 }
 function starUsers() {
-  for(var i = 0; i < users.length; i++) {
+  for (var i = 0; i < users.length; i++) {
     users.starred = true;
   }
 }
 function displayUserInfo() {
-  if(!users) {
+  if (!users) {
     StackdriverErrors.report('No user information to display');
   }
 }

gulpfile.js

@@ -25,18 +25,18 @@ var SRC_FILE = 'stackdriver-errors.js';
 var DEST = 'dist/';
 
 var dependencies = [
-    './node_modules/stacktrace-js/dist/stacktrace-with-promises-and-json-polyfills.js',
+  './node_modules/stacktrace-js/dist/stacktrace-with-promises-and-json-polyfills.js',
 ];
 
 gulp.task('dist', function() {
   return gulp.src(dependencies.concat(SRC_FILE))
-    .pipe(sourcemaps.init({ loadMaps: true }))
+    .pipe(sourcemaps.init({loadMaps: true}))
     .pipe(concat(SRC_FILE.replace('.js', '-concat.js')))
     // This will output the non-minified version
     .pipe(gulp.dest(DEST))
     // This will minify and rename to stackdriver-errors.min.js
     .pipe(uglify())
-    .pipe(rename({ extname: '.min.js' }))
+    .pipe(rename({extname: '.min.js'}))
     .pipe(sourcemaps.write('maps'))
     .pipe(gulp.dest(DEST));
 });
@@ -53,7 +53,7 @@ gulp.task('demo-js', function() {
   return gulp.src('demo/demo.js')
     .pipe(sourcemaps.init())
     .pipe(uglify())
-    .pipe(rename({ extname: '.min.js' }))
+    .pipe(rename({extname: '.min.js'}))
     .pipe(sourcemaps.write('maps'))
     .pipe(gulp.dest('dist'));
 });

stackdriver-errors.js

@@ -40,13 +40,13 @@
    * @param {Boolean} [config.disabled=false] - Set to true to not report errors when calling report(), this can be used when developping locally.
    */
   StackdriverErrorReporter.prototype.start = function(config) {
-    if(!config.key && !config.targetUrl) {
+    if (!config.key && !config.targetUrl) {
       throw new Error('Cannot initialize: No API key or target url provided.');
     }
-    if(!config.projectId && !config.targetUrl) {
+    if (!config.projectId && !config.targetUrl) {
       throw new Error('Cannot initialize: No project ID or target url provided.');
     }
-    if(typeof StackTrace === 'undefined') {
+    if (typeof StackTrace === 'undefined') {
       // Inform about missing dependency
       throw new Error('make sure you loaded “dist/stackdriver-errors-concat.js” or “dist/stackdriver-errors-concat.min.js”, or that you imported the “stacktrace-js” module');
     }
@@ -56,7 +56,7 @@
     this.targetUrl = config.targetUrl;
     this.context = config.context || {};
     this.serviceContext = {service: config.service || 'web'};
-    if(config.version) {
+    if (config.version) {
       this.serviceContext.version = config.version;
     }
     this.reportUncaughtExceptions = config.reportUncaughtExceptions !== false;
@@ -66,22 +66,22 @@
     // Register as global error handler if requested
     var noop = function() {};
     var that = this;
-    if(this.reportUncaughtExceptions) {
+    if (this.reportUncaughtExceptions) {
       var oldErrorHandler = window.onerror || noop;
 
       window.onerror = function(message, source, lineno, colno, error) {
-        if(error){
+        if (error) {
           that.report(error).catch(noop);
         }
         oldErrorHandler(message, source, lineno, colno, error);
         return true;
       };
     }
-    if(this.reportUnhandledPromiseRejections) {
+    if (this.reportUnhandledPromiseRejections) {
       var oldPromiseRejectionHandler = window.onunhandledrejection || noop;
 
       window.onunhandledrejection = function(promiseRejectionEvent) {
-        if(promiseRejectionEvent){
+        if (promiseRejectionEvent) {
           that.report(promiseRejectionEvent.reason).catch(noop);
         }
         oldPromiseRejectionHandler(promiseRejectionEvent.reason);
@@ -96,10 +96,10 @@
    * @returns {Promise} A promise that completes when the report has been sent.
    */
   StackdriverErrorReporter.prototype.report = function(err) {
-    if(this.disabled) {
+    if (this.disabled) {
       return Promise.resolve(null);
     }
-    if(!err) {
+    if (!err) {
       return Promise.reject(new Error('no error to report'));
     }
 
@@ -108,15 +108,15 @@
     payload.context = this.context;
     payload.context.httpRequest = {
       userAgent: window.navigator.userAgent,
-      url: window.location.href
+      url: window.location.href,
     };
 
     var firstFrameIndex = 0;
-    if(typeof err == 'string' || err instanceof String) {
+    if (typeof err == 'string' || err instanceof String) {
       // Transform the message in an error, use try/catch to make sure the stacktrace is populated.
       try {
         throw new Error(err);
-      } catch(e) {
+      } catch (e) {
         err = e;
       }
       // the first frame when using report() is always this library
@@ -125,15 +125,15 @@
     var that = this;
     // This will use sourcemaps and normalize the stack frames
     // eslint-disable-next-line no-undef
-    return StackTrace.fromError(err).then(function(stack){
+    return StackTrace.fromError(err).then(function(stack) {
       payload.message = err.toString();
-      for(var s = firstFrameIndex; s < stack.length; s++) {
+      for (var s = firstFrameIndex; s < stack.length; s++) {
         payload.message += '\n';
         // Reconstruct the stackframe to a JS stackframe as expected by Error Reporting parsers.
         // stack[s].source should not be used because not populated when created from source map.
-        // 
+        //
         // If functionName or methodName isn't available <anonymous> will be used as the name.
-        payload.message += ['    at ', stack[s].getFunctionName() || '<anonymous>', ' (', stack[s].getFileName(), ':', stack[s].getLineNumber() ,':', stack[s].getColumnNumber() , ')'].join('');
+        payload.message += ['    at ', stack[s].getFunctionName() || '<anonymous>', ' (', stack[s].getFileName(), ':', stack[s].getLineNumber(), ':', stack[s].getColumnNumber(), ')'].join('');
       }
       return that.sendErrorPayload(payload);
     }, function(reason) {

test/setup.js

@@ -9,7 +9,7 @@ var stackdriverErrors = require('../stackdriver-errors');
 global.StackdriverErrorReporter = stackdriverErrors.StackdriverErrorReporter;
 
 global.window = window = {
-  location: { href: 'http://stackdriver-errors.test/' },
-  navigator: { userAgent: 'FakeAgent' },
+  location: {href: 'http://stackdriver-errors.test/'},
+  navigator: {userAgent: 'FakeAgent'},
 };
 global.XMLHttpRequest = sinon.FakeXMLHttpRequest;