Skip to content

Broad-Side self-scan: unverified leads needing triage #134

Description

@TheAmericanMaker

Type: triage · Source: Broad-Side batch self-scan of this repo (run 2026-08-23T05-52-23-986Z, .codecarto/broadside/ state retained 30 days on OpenRouter; raw results in the repo's gitignored broadside dir).

These leads were reported by the batch model but could not be verified on quick inspection. They may be real, wrong, or already-safe. Triaging each is cheap; believing them is not.

  • [med] Unchecked spread of optional open_questionscore/completion.ts spreads existingPhase.open_questions. Quick check: existingPhase derives from normalizeStatus, which guarantees arrays — likely a false positive. Re-check legacy-status paths.
  • [low] Unchecked getWorkspaceState return before accessing pipelineextensions/codecarto/ session-management paths. Unverified.
  • [low] Unsafe type assertion on msg.content in getLastAssistantTextextensions/codecarto/agent-runner.ts. Unverified.
  • [low] Non-reflexive sort comparator for closeout dates — unverified; find the comparator and test equal dates.
  • [low] Missing absolute path validation in handleLibraryInit — unverified; compare against validateCwd usage elsewhere.
  • [low] YAML parser: escaped-backslash handling in quoted scalars — quick tests of parseSimpleYaml did not reproduce ('key: "a\\\\b"' parses correctly). Likely false or an edge I didn't hit.
  • [low] YAML parser: single-character quote scalar parsed as empty — did not reproduce ('key: 'a'' parses correctly).
  • [low] Unnormalized trailing newline in thread-log append — cosmetic; unverified.
  • [low] Unkeyed entries discarded when merging open questions — unverified.

Context: Broad-Side is the new batch reconnaissance feature (branch feat/103-broadside, PR not yet opened). Its whole contract is 'unverified scouting leads, never evidence' — this issue is that contract in practice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions