Skip to content

Commit 8d79a05

Browse files
DEV-15014: Update field blueprint prompt_config to use description (#448)
1 parent 30383c7 commit 8d79a05

2 files changed

Lines changed: 42 additions & 16 deletions

File tree

indico/queries/field_blueprints.py

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,14 @@ class CreateFieldBlueprint(GraphQLRequest["List[FieldBlueprint]"]):
4444
datatype
4545
required
4646
multiple
47+
validationConfig
48+
formatConfig
49+
inputConfig
4750
}
4851
}
4952
promptConfig {
5053
... on ExtractionPromptConfig {
51-
prompt
54+
description
5255
targetName
5356
multipleValues
5457
minimumLocationType
@@ -100,23 +103,18 @@ class GetFieldBlueprints(GraphQLRequest["List[FieldBlueprint]"]):
100103
updatedBy
101104
fieldConfig {
102105
... on ExtractionFieldConfig {
103-
name
104106
name
105107
datatype
106108
required
107109
multiple
108-
validationConfig {
109-
settingName
110-
settingValue
111-
onFailure
112-
}
110+
validationConfig
113111
formatConfig
114112
inputConfig
115113
}
116114
}
117115
promptConfig {
118116
... on ExtractionPromptConfig {
119-
prompt
117+
description
120118
localization
121119
targetName
122120
multipleValues
@@ -171,23 +169,18 @@ class ListFieldBlueprints(PagedRequestV2["List[FieldBlueprint]"]):
171169
updatedBy
172170
fieldConfig {
173171
... on ExtractionFieldConfig {
174-
name
175172
name
176173
datatype
177174
required
178175
multiple
179-
validationConfig {
180-
settingName
181-
settingValue
182-
onFailure
183-
}
176+
validationConfig
184177
formatConfig
185178
inputConfig
186179
}
187180
}
188181
promptConfig {
189182
... on ExtractionPromptConfig {
190-
prompt
183+
description
191184
localization
192185
targetName
193186
multipleValues

tests/test_field_blueprints.py

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@ def mock_field_blueprint_data():
2828
"updatedBy": 1,
2929
"tags": ["test"],
3030
"fieldConfig": {"some": "config"},
31-
"promptConfig": {"localization": "SEARCH"},
31+
"promptConfig": {
32+
"description": "Find organization names in the document",
33+
"localization": "SEARCH",
34+
},
3235
}
3336

3437

@@ -47,6 +50,36 @@ def test_create_field_blueprint(mock_field_blueprint_data):
4750
assert result[0].uid == "test_uid"
4851
assert result[0].field_config["some"] == "config"
4952
assert result[0].prompt_config["localization"] == "SEARCH"
53+
assert (
54+
result[0].prompt_config["description"]
55+
== "Find organization names in the document"
56+
)
57+
58+
59+
def test_field_blueprint_queries_use_description_in_prompt_config():
60+
for query in (
61+
CreateFieldBlueprint.query,
62+
GetFieldBlueprints.query,
63+
ListFieldBlueprints.query,
64+
):
65+
assert "description" in query
66+
assert "\n prompt\n" not in query
67+
assert "\n prompt\n" not in query
68+
assert "\n prompt\n" not in query
69+
70+
71+
def test_field_blueprint_queries_use_scalar_validation_config():
72+
for query in (
73+
CreateFieldBlueprint.query,
74+
GetFieldBlueprints.query,
75+
ListFieldBlueprints.query,
76+
):
77+
assert "validationConfig" in query
78+
assert "formatConfig" in query
79+
assert "inputConfig" in query
80+
assert "validationConfig {" not in query
81+
assert "formatConfig {" not in query
82+
assert "inputConfig {" not in query
5083

5184

5285
def test_get_field_blueprints(mock_field_blueprint_data):

0 commit comments

Comments
 (0)