feat(lyrics): add immersive button to fullscreen lyrics header#124
Merged
Conversation
Mirrors the Mic2 "switch to lyrics" button that already exists in the FullscreenNowPlaying top bar. Previously the only path from Fullscreen Lyrics back to Immersive Now Playing was clicking the small cover thumbnail in the header — discoverable for users who read the hover title, but invisible otherwise. Reuses the existing `onOpenNowPlaying` callback (parent already flips the fullscreen mutex), the existing `playerBar.openFullscreen` i18n key, and the Maximize2 icon used by the player bar's primary immersive trigger. Closes #109
📝 WalkthroughWalkthroughAjout d'un bouton Maximize dans l'en-tête de Fullscreen Lyrics qui ouvre la vue Immersive Now Playing via ChangesAccès rapide à Immersive Now Playing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maximize2button next to the close X inFullscreenLyrics, symmetric to theMic2"switch to lyrics" button already present inFullscreenNowPlaying.onOpenNowPlayingcallback (parent already flips the fullscreen mutex) and the existingplayerBar.openFullscreeni18n key — no new strings, no plumbing changes.The pre-existing cover-thumbnail click on the header keeps working for users who already learned that gesture.
Closes #109
Test plan
Summary by CodeRabbit