Skip to content

docs(ui): note the symmetric Immersive button in FullscreenLyrics header#126

Merged
InstaZDLL merged 1 commit into
mainfrom
docs/fullscreen-lyrics-immersive-button
May 23, 2026
Merged

docs(ui): note the symmetric Immersive button in FullscreenLyrics header#126
InstaZDLL merged 1 commit into
mainfrom
docs/fullscreen-lyrics-immersive-button

Conversation

@InstaZDLL
Copy link
Copy Markdown
Owner

@InstaZDLL InstaZDLL commented May 23, 2026

Summary

Test plan

  • Render the docs / read the diff — wording reads naturally next to the existing PlayerBar entry-points sentence.

Summary by CodeRabbit

  • Documentation
    • Mise à jour de la documentation UI/UX pour Immersive Now Playing : clarification des points d'accès depuis la barre (clic cover et icône Maximize), navigation entre les vues Immersive et Lyrics fullscreen, et gestes de fermeture disponibles (Escape ou bouton X).

Review Change Stack

The Immersive Now Playing section listed PlayerBar entry points but
not the new Maximize2 button in the FullscreenLyrics header (added
in PR #124 / issue #109), which closes the round-trip Lyrics →
Immersive.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 867efbe1-c8f2-485b-99a3-125deba6940e

📥 Commits

Reviewing files that changed from the base of the PR and between 3012cd5 and eae3201.

📒 Files selected for processing (1)
  • docs/features/ui.md

📝 Walkthrough

Walkthrough

Mise à jour de la documentation UI/UX pour décrire l'overlay Immersive Now Playing : points d'entrée depuis PlayerBar (clic cover et bouton Maximize2), navigation bidirectionnelle vers Lyrics fullscreen, fermeture via Escape/X, et gestion locale de l'état sans PlayerContext.

Changes

Documentation Immersive Now Playing

Layer / File(s) Summary
Documentation de la navigation Immersive et fermeture fullscreen
docs/features/ui.md
Ajout d'une section décrivant les deux points d'entrée (clic cover et Maximize2), la navigation aller-retour Immersive ↔ Lyrics, la fermeture (Escape/X), et le mutex fullscreen maintenant une seule overlay active à la fois.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • InstaZDLL/WaveFlow#124: Implémentation du bouton Maximize2 dans FullscreenLyrics pour la navigation Immersive ↔ Lyrics que cette documentation décrit.

Poem

📖 La doc brille enfin claire,
Immersive danse en plein air,
Maximize2 fait les allers-retours,
Entre Lyrics et ombres du jour,
Le mutex veille, un seul overlay pour toujours ! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Le titre suit les Conventional Commits avec un scope kebab-case et décrit précisément l'ajout du bouton Maximize2 dans FullscreenLyrics.
Description check ✅ Passed La description couvre les sections essentielles : sommaire avec contexte, lien vers la PR/issue précédente, et plan de test (bien que partiel).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/fullscreen-lyrics-immersive-button

Comment @coderabbitai help to get the list of available commands and usage tips.

@InstaZDLL InstaZDLL added scope: docs Docs, README, assets type: docs Documentation size: xs < 10 lines labels May 23, 2026
@InstaZDLL InstaZDLL self-assigned this May 23, 2026
@InstaZDLL InstaZDLL merged commit 25c7ea3 into main May 23, 2026
13 checks passed
@InstaZDLL InstaZDLL deleted the docs/fullscreen-lyrics-immersive-button branch May 23, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs Docs, README, assets size: xs < 10 lines type: docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant