diff --git a/loader/wsi.c b/loader/wsi.c index cffd14b0b..ed27d620d 100644 --- a/loader/wsi.c +++ b/loader/wsi.c @@ -2207,12 +2207,6 @@ VKAPI_ATTR VkResult VKAPI_CALL terminator_CreateSharedSwapchainsKHR(VkDevice dev "[VUID-vkCreateSharedSwapchainsKHR-device-parameter]"); abort(); /* Intentionally fail so user can correct issue. */ } - if (NULL != icd_term->surface_list.list) { - loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0, - "vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created, indicating an application " - "bug. Returning VK_SUCCESS. "); - return VK_SUCCESS; - } if (NULL == dev->loader_dispatch.extension_terminator_dispatch.CreateSharedSwapchainsKHR) { loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0, "vkCreateSharedSwapchainsKHR Terminator: Driver's function pointer was NULL, returning VK_SUCCESS. Was the " diff --git a/tests/loader_get_proc_addr_tests.cpp b/tests/loader_get_proc_addr_tests.cpp index 89fa51ac9..d37a786fd 100644 --- a/tests/loader_get_proc_addr_tests.cpp +++ b/tests/loader_get_proc_addr_tests.cpp @@ -294,7 +294,10 @@ TEST(GetDeviceProcAddr, SwapchainFuncsWithTerminator) { infos[1].sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR; infos[1].surface = surface2; - ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, 2, infos.data(), nullptr, &swapchain)); + std::array swapchains{}; + ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, static_cast(swapchains.size()), infos.data(), nullptr, + swapchains.data())); + ASSERT_FALSE(log.find("vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created")); } env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface, nullptr); env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface2, nullptr);