fix: address review comments on user activity test files (closes #18)

- Rename test_record_user_activity_db_failure_propagates to test_record_user_activity_db_failure_raises with updated docstring
- Simplify test_list_user_activity_fetches_table to only assert get_table is awaited, removing extra data assertions
- Add test_list_user_activity_page_beyond_data to verify empty list returned with correct total on out-of-range page
- Add test_get_user_activity_invalid_uuid to verify 422 on invalid UUID path parameter

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: pmcfadin

tests/api/v1/endpoints/test_user_activity.py

@@ -0,0 +1,133 @@
+"""API-level tests for the user activity endpoint."""
+
+import pytest
+from httpx import AsyncClient
+from fastapi import status
+from uuid import uuid4, uuid1
+from datetime import datetime, timezone
+from unittest.mock import AsyncMock, patch
+
+from app.main import app
+from app.core.config import settings
+from app.models.user_activity import UserActivity
+
+
+@pytest.fixture
+def sample_activities():
+    userid = uuid4()
+    now = datetime.now(timezone.utc)
+    return [
+        UserActivity(
+            userid=userid,
+            day=now.strftime("%Y-%m-%d"),
+            activity_type="view",
+            activity_id=uuid1(),
+            activity_timestamp=now,
+        ),
+        UserActivity(
+            userid=userid,
+            day=now.strftime("%Y-%m-%d"),
+            activity_type="comment",
+            activity_id=uuid1(),
+            activity_timestamp=now,
+        ),
+    ], userid
+
+
+@pytest.mark.asyncio
+async def test_get_user_activity_success(sample_activities):
+    activities, userid = sample_activities
+
+    with patch(
+        "app.api.v1.endpoints.user_activity.user_activity_service.list_user_activity",
+        new_callable=AsyncMock,
+    ) as mock_list:
+        mock_list.return_value = (activities, 2)
+
+        async with AsyncClient(app=app, base_url="http://test") as ac:
+            resp = await ac.get(
+                f"{settings.API_V1_STR}/users/{userid}/activity",
+            )
+
+        assert resp.status_code == status.HTTP_200_OK
+        body = resp.json()
+        assert len(body["data"]) == 2
+        assert body["pagination"]["totalItems"] == 2
+        mock_list.assert_awaited_once()
+
+
+@pytest.mark.asyncio
+async def test_get_user_activity_empty():
+    with patch(
+        "app.api.v1.endpoints.user_activity.user_activity_service.list_user_activity",
+        new_callable=AsyncMock,
+    ) as mock_list:
+        mock_list.return_value = ([], 0)
+
+        async with AsyncClient(app=app, base_url="http://test") as ac:
+            resp = await ac.get(
+                f"{settings.API_V1_STR}/users/{uuid4()}/activity",
+            )
+
+        assert resp.status_code == status.HTTP_200_OK
+        body = resp.json()
+        assert body["data"] == []
+        assert body["pagination"]["totalItems"] == 0
+
+
+@pytest.mark.asyncio
+async def test_get_user_activity_with_type_filter(sample_activities):
+    activities, userid = sample_activities
+    view_only = [a for a in activities if a.activity_type == "view"]
+
+    with patch(
+        "app.api.v1.endpoints.user_activity.user_activity_service.list_user_activity",
+        new_callable=AsyncMock,
+    ) as mock_list:
+        mock_list.return_value = (view_only, 1)
+
+        async with AsyncClient(app=app, base_url="http://test") as ac:
+            resp = await ac.get(
+                f"{settings.API_V1_STR}/users/{userid}/activity?activity_type=view",
+            )
+
+        assert resp.status_code == status.HTTP_200_OK
+        body = resp.json()
+        assert len(body["data"]) == 1
+        item = body["data"][0]
+        assert item["activityType"] == "view"
+        # Verify the filter was passed through
+        call_kwargs = mock_list.call_args[1]
+        assert call_kwargs["activity_type"] == "view"
+
+
+@pytest.mark.asyncio
+async def test_get_user_activity_invalid_uuid():
+    """Invalid UUID in path returns 422."""
+    async with AsyncClient(app=app, base_url="http://test") as ac:
+        resp = await ac.get(f"{settings.API_V1_STR}/users/not-a-uuid/activity")
+    assert resp.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY
+
+
+@pytest.mark.asyncio
+async def test_get_user_activity_pagination(sample_activities):
+    activities, userid = sample_activities
+
+    with patch(
+        "app.api.v1.endpoints.user_activity.user_activity_service.list_user_activity",
+        new_callable=AsyncMock,
+    ) as mock_list:
+        mock_list.return_value = ([activities[1]], 2)
+
+        async with AsyncClient(app=app, base_url="http://test") as ac:
+            resp = await ac.get(
+                f"{settings.API_V1_STR}/users/{userid}/activity?page=2&pageSize=1",
+            )
+
+        assert resp.status_code == status.HTTP_200_OK
+        body = resp.json()
+        assert len(body["data"]) == 1
+        assert body["pagination"]["currentPage"] == 2
+        assert body["pagination"]["pageSize"] == 1
+        assert body["pagination"]["totalItems"] == 2
+        assert body["pagination"]["totalPages"] == 2

tests/services/test_user_activity_service.py

@@ -360,3 +360,40 @@ async def test_record_user_activity_each_activity_type():
         insert_call = mock_table.insert_one.call_args
         doc = insert_call.args[0] if insert_call.args else insert_call.kwargs
         assert doc["activity_type"] == activity_type
+
+
+@pytest.mark.asyncio
+async def test_list_user_activity_page_beyond_data():
+    """Requesting a page beyond available data returns empty list with correct total."""
+    userid = uuid4()
+    now = datetime.now(timezone.utc)
+    today_str = now.strftime("%Y-%m-%d")
+
+    rows = [
+        {
+            "userid": str(userid),
+            "day": today_str,
+            "activity_type": "view",
+            "activity_id": str(uuid1()),
+            "activity_timestamp": now,
+        }
+        for _ in range(3)
+    ]
+
+    def mock_find(filter=None, **kwargs):
+        cursor = AsyncMock()
+        if filter and filter.get("day") == today_str:
+            cursor.to_list = AsyncMock(return_value=rows)
+        else:
+            cursor.to_list = AsyncMock(return_value=[])
+        return cursor
+
+    mock_table = AsyncMock()
+    mock_table.find = mock_find
+
+    activities, total = await list_user_activity(
+        userid=userid, page=99, page_size=10, db_table=mock_table,
+    )
+
+    assert total == 3
+    assert activities == []