fix: activity tracking persists on views-counter failure, passes video_id (closes #14)

- Remove early `return` from UNKNOWN_TABLE_COLUMNS/UNSUPPORTED_UPDATE_OPERATIONS
  branch so video_activity and user_activity inserts still run even when the
  views counter update is unavailable.
- Pass `activity_id=video_id` to `record_user_activity` so each user_activity
  row links back to the video that was viewed.
- Add `record_user_activity` patch + `assert_awaited_once` to
  `test_record_video_view_success` as a regression guard.
- Update `test_record_video_view_authenticated_user_activity` and
  `test_record_video_view_anonymous_user_activity` assertions to include
  the new `activity_id=vid` kwarg.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: pmcfadin

app/services/video_service.py

@@ -427,7 +427,7 @@ async def record_video_view(
                     "UNSUPPORTED_UPDATE_OPERATIONS_FOR_TABLE"
                 )
                 _logged_views_disabled = True
-            return  # Gracefully no-op without breaking the API contract
+            pass  # Gracefully no-op for views counter; continue to activity tracking below
 
         # Some deployments (Astra *tables*) currently reject $inc on bigint –
         # fall back to a manual read-modify-write cycle.
@@ -477,6 +477,7 @@ async def record_video_view(
         await record_user_activity(
             userid=effective_user_id,
             activity_type="view",
+            activity_id=video_id,
         )
     except Exception:
         logger.warning("user_activity insert failed for view; ignoring", exc_info=True)

tests/services/test_video_service.py

@@ -236,9 +236,15 @@ async def test_record_video_view_success():
     # Mock the activity table returned via get_table
     mock_activity_table = AsyncMock()
 
-    with patch(
-        "app.services.video_service.get_table", new_callable=AsyncMock
-    ) as mock_get_table:
+    with (
+        patch(
+            "app.services.video_service.get_table", new_callable=AsyncMock
+        ) as mock_get_table,
+        patch(
+            "app.services.user_activity_service.record_user_activity",
+            new_callable=AsyncMock,
+        ) as mock_record_user_activity,
+    ):
         # First call inside record_video_view is for VIDEO_PLAYBACK_STATS_TABLE_NAME
         # but we already pass mock_stats_table, so get_table will be used only once
         mock_get_table.return_value = mock_activity_table
@@ -253,6 +259,9 @@ async def test_record_video_view_success():
         # Validate activity table log
         mock_activity_table.insert_one.assert_called_once()
 
+        # Validate user activity was tracked (regression guard)
+        mock_record_user_activity.assert_awaited_once()
+
 
 @pytest.mark.asyncio
 async def test_record_video_view_authenticated_user_activity():
@@ -277,10 +286,11 @@ async def test_record_video_view_authenticated_user_activity():
             vid, viewer_user_id=viewer_id, db_table=mock_stats_table
         )
 
-        # record_user_activity should be called with the real user ID
+        # record_user_activity should be called with the real user ID and video_id
         mock_record_user_activity.assert_awaited_once_with(
             userid=viewer_id,
             activity_type="view",
+            activity_id=vid,
         )
 
 
@@ -308,10 +318,11 @@ async def test_record_video_view_anonymous_user_activity():
             vid, viewer_user_id=None, db_table=mock_stats_table
         )
 
-        # record_user_activity should be called with the anonymous sentinel UUID
+        # record_user_activity should be called with the anonymous sentinel UUID and video_id
         mock_record_user_activity.assert_awaited_once_with(
             userid=ANONYMOUS_USER_ID,
             activity_type="view",
+            activity_id=vid,
         )