Crash in flutter 3.35.7 dart 3.9.2 after upgraded to 0.3.0. Name.byReference need library reference

[cenumi]

Minimal reproducible example:

  import 'dart:ffi' as ffi;
  import 'dart:typed_data';

  @ffi.Native<ffi.Void Function(ffi.Pointer<ffi.Void>)>(isLeaf: true, symbol: 'free')
  external void _native(ffi.Pointer<ffi.Void> data);

  void probe(Uint8List bytes) {
    _native(bytes.address.cast<ffi.Void>());
  }

  void main() {}

Crash log

Crash when compiling:
Null check operator used on a null value

#0 new Name.byReference (package:kernel/src/ast/names.dart:40:48)
#1 new Name (package:kernel/src/ast/names.dart:33:11)
#2 _FfiUseSiteTransformer._replaceNativeCall (package:vm/modular/transformations/ffi/use_sites.dart:2013:24)
#3 _FfiUseSiteTransformer._visitStaticInvocation (package:vm/modular/transformations/ffi/use_sites.dart:675:18)
#4 _FfiUseSiteTransformer.visitStaticInvocation (package:vm/modular/transformations/ffi/use_sites.dart:239:32)
#5 StaticInvocation.accept (package:kernel/src/ast/expressions.dart:2602:44)
#6 Transformer.transform (package:kernel/visitor.dart:1771:17)
#7 ExpressionStatement.transformChildren (package:kernel/src/ast/statements.dart:63:20)
#8 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805:10)
#9 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622:41)
#10 StatementVisitorDefaultMixin.visitExpressionStatement (package:kernel/visitor.dart:343:7)
#11 ExpressionStatement.accept (package:kernel/src/ast/statements.dart:50:43)
#12 Transformer.transform (package:kernel/visitor.dart:1771:17)
#13 Transformer.transformList (package:kernel/visitor.dart:1788:18)
#14 Block.transformChildren (package:kernel/src/ast/statements.dart:115:7)
#15 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805:10)
#16 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622:41)
#17 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345:31)
#18 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168:19)
#19 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60:21)
#20 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166:12)
#21 Block.accept (package:kernel/src/ast/statements.dart:103:43)
#22 Transformer.transform (package:kernel/visitor.dart:1771:17)
#23 FunctionNode.transformChildren (package:kernel/src/ast/functions.dart:247:16)
#24 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805:10)
#25 TreeVisitorDefaultMixin.visitFunctionNode (package:kernel/visitor.dart:577:45)
#26 FunctionNode.accept (package:kernel/src/ast/functions.dart:214:38)
#27 Transformer.transform (package:kernel/visitor.dart:1771:17)
#28 Procedure.transformChildren (package:kernel/src/ast/members.dart:1245:18)
#29 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805:10)
#30 TreeVisitorDefault.defaultMember (package:kernel/visitor.dart:626:35)
#31 MemberVisitorDefaultMixin.visitProcedure (package:kernel/visitor.dart:411:39)
#32 _FfiUseSiteTransformer.visitProcedure (package:vm/modular/transformations/ffi/use_sites.dart:232:26)
#33 FinalizableTransformer.visitProcedure. (package:vm/modular/transformations/ffi/finalizable.dart:155:19)
#34 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60:21)
#35 FinalizableTransformer.visitProcedure (package:vm/modular/transformations/ffi/finalizable.dart:153:20)
#36 Procedure.accept (package:kernel/src/ast/members.dart:1226:40)
#37 Transformer.transform (package:kernel/visitor.dart:1771:17)
#38 Transformer.transformList (package:kernel/visitor.dart:1788:18)
#39 Library.transformChildren (package:kernel/src/ast/libraries.dart:320:7)
#40 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805:10)
#41 TreeVisitorDefaultMixin.visitLibrary (package:kernel/visitor.dart:565:35)
#42 FfiTransformer.visitLibrary (package:vm/modular/transformations/ffi/common.dart:1073:26)
#43 _FfiUseSiteTransformer.visitLibrary (package:vm/modular/transformations/ffi/use_sites.dart:133:18)
#44 List.forEach (dart:core-patch/growable_array.dart:425:8)
#45 transformLibraries (package:vm/modular/transformations/ffi/use_sites.dart:80:13)
#46 VmTarget.performModularTransformationsOnLibraries (package:vm/modular/target/vm.dart:227:28)
#47 KernelTarget.runBuildTransformations (package:front_end/src/kernel/kernel_target.dart:1611:19)
#48 KernelTarget.buildComponent. (package:front_end/src/kernel/kernel_target.dart:706:7)

#49 withCrashReporting (package:front_end/src/base/crash.dart:139:12)

#50 KernelTarget.buildComponent (package:front_end/src/kernel/kernel_target.dart:647:12)

#51 _buildInternal (package:front_end/src/kernel_generator_impl.dart:209:19)

#52 withCrashReporting (package:front_end/src/base/crash.dart:139:12)

#53 generateKernel. (package:front_end/src/kernel_generator_impl.dart:45:12)

#54 CompilerContext.clear (package:front_end/src/base/compiler_context.dart:77:3)

#55 generateKernel (package:front_end/src/kernel_generator_impl.dart:43:10)

#56 kernelForModule (package:front_end/src/api_prototype/kernel_generator.dart:107:11)

#57 SingleShotCompilerWrapper.compileInternal (file:///Volumes/Work/s/w/ir/x/w/sdk/pkg/vm/bin/kernel_service.dart:464:15)

#58 Compiler.compile. (file:///Volumes/Work/s/w/ir/x/w/sdk/pkg/vm/bin/kernel_service.dart:237:45)

#59 _processLoadRequest (file:///Volumes/Work/s/w/ir/x/w/sdk/pkg/vm/bin/kernel_service.dart:1024:37)

Passed example:

import 'dart:ffi' as ffi;
import 'dart:typed_data';

@ffi.Native<ffi.Void Function(ffi.Pointer<ffi.Void>)>(isLeaf: true, symbol: 'free')
external void native(ffi.Pointer<ffi.Void> data);

void probe(Uint8List bytes) {
  native(bytes.address.cast<ffi.Void>());
}

void main() {}

[Knightro63]

Hi @cenumi,

I have upgraded Flutter to version 3.41.9 and dart to 3.11.5 with no issues. Can you give me some more details about the error.

I currently don't use the above code anywhere that I remember and all ffi is handled in flutter_angle.

[cenumi]

Sorry, I should have opened an issue there instead. Below is the relevant code that may be causing the problem.
https://github.com/Knightro63/flutter_angle/blob/main/flutter_angle/lib/desktop/bindings/gles_bindings.dart

[don-poiz]

Hi, @cenumi.
I get exactly the same error and can't launch the app. Please tell me how you fixed the error. I can't fix it. 😢

Thank you 😄

[cenumi]

Hi, @cenumi. I get exactly the same error and can't launch the app. Please tell me how you fixed the error. I can't fix it. 😢

Thank you 😄

Fork flutter_angle, in lib/desktop/bindings/gles_bindings.dart, change all @ffi.Native functions to public
example: _glBufferData -> nativeGlBufferData

[Knightro63]

Hi @cenumi and @don-poiz ,

I have been updating flutter_angle to fix the issue. As long as you are not building for macos you can update to the newest version of flutter_angle with an override from github. I have not updated the pub dev version yet due to the move from CocoaPods to SPM, which is breaking macos with some symlink issues.

dependency_overrides:
  flutter_angle:
    git:
      url: https://github.com/Knightro63/flutter_angle.git 
      path: flutter_angle

[don-poiz]

@Knightro63 thanks for the reply.
But the problem persists when running on the Pixel 9 Pro Android Emulator and on a real device.

If running on the web, everything works fine.

[Knightro63]

Hi @don-poiz,

Thanks for letting me know. I will take a look. I redid everything to be the latest version of ffi. I am wondering if there is a flutter bug I am not aware of. I will take a look.

Thank you

[don-poiz]

P.S.
I thought the problem was due to a conflict with other third-party packages.
But I created a new project with only three_js as a dependency, and the error persists on both the emulator and the real device.

[cenumi]

Hi @don-poiz,

Thanks for letting me know. I will take a look. I redid everything to be the latest version of ffi. I am wondering if there is a flutter bug I am not aware of. I will take a look.

Thank you

Reproduced with flutter 3.35.7 and new git branch, same error.
It is a Dart bug.

Dart 3.9.2 crashes in _FfiUseSiteTransformer when it
generates a transformed private method name without a library reference.

Declear all @ffi.Native methods such as _glBufferData to public to fix it.

Details

Unhandled exception:
Null check operator used on a null value
#0 new Name.byReference (package:kernel/src/ast/names.dart:40)
#1 new Name (package:kernel/src/ast/names.dart:33)
#2 _FfiUseSiteTransformer._replaceNativeCall (package:vm/modular/transformations/ffi/use_sites.dart:2013)
#3 _FfiUseSiteTransformer._visitStaticInvocation (package:vm/modular/transformations/ffi/use_sites.dart:675)
#4 _FfiUseSiteTransformer.visitStaticInvocation (package:vm/modular/transformations/ffi/use_sites.dart:239)
#5 StaticInvocation.accept (package:kernel/src/ast/expressions.dart:2602)
#6 Transformer.transform (package:kernel/visitor.dart:1771)
#7 SpreadMapEntry.transformChildren (package:front_end/src/kernel/collections.dart:767)
#8 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#9 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#10 StatementVisitorDefaultMixin.visitIfCaseStatement (package:kernel/visitor.dart:375)
#11 ExpressionStatement.accept (package:kernel/src/ast/statements.dart:50)
#12 Transformer.transform (package:kernel/visitor.dart:1771)
#13 Transformer.transformList (package:kernel/visitor.dart:1788)
#14 AssertBlock.transformChildren (package:kernel/src/ast/statements.dart:162)
#15 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#16 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622)
#17 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345)
#18 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168)
#19 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#20 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166)
#21 Block.accept (package:kernel/src/ast/statements.dart:103)
#22 Transformer.transform (package:kernel/visitor.dart:1771)
#23 Transformer.transformList (package:kernel/visitor.dart:1788)
#24 AssertBlock.transformChildren (package:kernel/src/ast/statements.dart:162)
#25 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#26 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622)
#27 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345)
#28 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168)
#29 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#30 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166)
#31 Block.accept (package:kernel/src/ast/statements.dart:103)
#32 Transformer.transform (package:kernel/visitor.dart:1771)
#33 IfStatement.transformChildren (package:kernel/src/ast/statements.dart:1030)
#34 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#35 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#36 StatementVisitorDefaultMixin.visitIfCaseStatement (package:kernel/visitor.dart:375)
#37 IfStatement.accept (package:kernel/src/ast/statements.dart:1013)
#38 Transformer.transform (package:kernel/visitor.dart:1771)
#39 Transformer.transformList (package:kernel/visitor.dart:1788)
#40 AssertBlock.transformChildren (package:kernel/src/ast/statements.dart:162)
#41 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#42 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622)
#43 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345)
#44 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168)
#45 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#46 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166)
#47 Block.accept (package:kernel/src/ast/statements.dart:103)
#48 Transformer.transform (package:kernel/visitor.dart:1771)
#49 Transformer.transformList (package:kernel/visitor.dart:1788)
#50 AssertBlock.transformChildren (package:kernel/src/ast/statements.dart:162)
#51 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#52 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622)
#53 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345)
#54 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168)
#55 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#56 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166)
#57 Block.accept (package:kernel/src/ast/statements.dart:103)
#58 Transformer.transform (package:kernel/visitor.dart:1771)
#59 LabeledStatement.transformChildren (package:kernel/src/ast/statements.dart:319)
#60 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#61 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#62 StatementVisitorDefaultMixin.visitIfCaseStatement (package:kernel/visitor.dart:375)
#63 FinalizableTransformer.visitLabeledStatement (package:vm/modular/transformations/ffi/finalizable.dart:477)
#64 LabeledStatement.accept (package:kernel/src/ast/statements.dart:306)
#65 Transformer.transform (package:kernel/visitor.dart:1771)
#66 Transformer.transformList (package:kernel/visitor.dart:1788)
#67 AssertBlock.transformChildren (package:kernel/src/ast/statements.dart:162)
#68 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#69 TreeVisitorDefault.defaultStatement (package:kernel/visitor.dart:622)
#70 StatementVisitorDefaultMixin.visitBlock (package:kernel/visitor.dart:345)
#71 FinalizableTransformer.visitBlock. (package:vm/modular/transformations/ffi/finalizable.dart:168)
#72 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#73 FinalizableTransformer.visitBlock (package:vm/modular/transformations/ffi/finalizable.dart:166)
#74 Block.accept (package:kernel/src/ast/statements.dart:103)
#75 Transformer.transform (package:kernel/visitor.dart:1771)
#76 FunctionNode.transformChildren (package:kernel/src/ast/functions.dart:247)
#77 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#78 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#79 FunctionNode.accept (package:kernel/src/ast/functions.dart:214)
#80 Transformer.transform (package:kernel/visitor.dart:1771)
#81 Procedure.transformChildren (package:kernel/src/ast/members.dart:1245)
#82 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#83 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#84 MemberVisitorDefaultMixin.visitProcedure (package:kernel/visitor.dart:411)
#85 _FfiUseSiteTransformer.visitProcedure (package:vm/modular/transformations/ffi/use_sites.dart:232)
#86 FinalizableTransformer.visitProcedure. (package:vm/modular/transformations/ffi/finalizable.dart:155)
#87 FinalizableTransformer.inScope (package:vm/modular/transformations/ffi/finalizable.dart:60)
#88 FinalizableTransformer.visitProcedure (package:vm/modular/transformations/ffi/finalizable.dart:153)
#89 Procedure.accept (package:kernel/src/ast/members.dart:1226)
#90 Transformer.transform (package:kernel/visitor.dart:1771)
#91 Transformer.transformList (package:kernel/visitor.dart:1788)
#92 Library.transformChildren (package:kernel/src/ast/libraries.dart:320)
#93 Transformer.defaultTreeNode (package:kernel/visitor.dart:1805)
#94 TreeVisitorDefault.defaultExpression (package:kernel/visitor.dart:618)
#95 FfiTransformer.visitLibrary (package:vm/modular/transformations/ffi/common.dart:1073)
#96 _FfiUseSiteTransformer.visitLibrary (package:vm/modular/transformations/ffi/use_sites.dart:133)
#97 List.forEach (dart:core-patch/growable_array.dart:425)
#98 transformLibraries (package:vm/modular/transformations/ffi/use_sites.dart:80)
#99 VmTarget.performModularTransformationsOnLibraries (package:vm/modular/target/vm.dart:227)
#100 KernelTarget.runBuildTransformations (package:front_end/src/kernel/kernel_target.dart:1611)
#101 KernelTarget.buildComponent. (package:front_end/src/kernel/kernel_target.dart:706)

#102 withCrashReporting (package:front_end/src/base/crash.dart:139)

#103 KernelTarget.buildComponent (package:front_end/src/kernel/kernel_target.dart:647)

#104 IncrementalCompiler.computeDelta. (package:front_end/src/base/incremental_compiler.dart:375)

#105 CompilerContext.clear (package:front_end/src/base/compiler_context.dart:77)

#106 IncrementalCompiler.compile (package:vm/incremental_compiler.dart:86)

#107 FrontendCompiler.compile (package:frontend_server/frontend_server.dart:655)

#108 listenAndCompile. (package:frontend_server/frontend_server.dart:1423)

The Dart compiler exited unexpectedly.
The Dart compiler exited unexpectedly.