From 123da5f14b81458d987a65684d1a5278156a3ea5 Mon Sep 17 00:00:00 2001 From: Marty Pradere Date: Sun, 10 May 2026 17:22:36 -0700 Subject: [PATCH] Co-locate Claude review checklists with their skills The .agents/ directory only existed to host review-checklist files referenced by two .claude/skills/ skills (code-review-jest and code-review-react). Each skill.md reached across the tree via ../../../.agents/review-checklists/..., which is more fragile and less self-contained than the established skill pattern (e.g. wcag-compliance keeps its checklist next to its skill.md). Co-locate the rule files with their skills, and factor the shared reviewer-priority and review-format guidance into a single file at .claude/skills/review-priority-and-format.md (renamed from common.md to describe its contents). * Move jest checklists from .agents/review-checklists/jest/ into .claude/skills/code-review-jest/. * Move react checklists from .agents/review-checklists/react/ into .claude/skills/code-review-react/. * Promote shared guidance to .claude/skills/review-priority-and-format.md; both code-review skills now reference it via ../review-priority-and-format.md. * Update the Prerequisite link at the top of each rule file to the new shared path -- these had been dangling after the move. * Remove the now-empty .agents/ directory. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../jest => .claude/skills/code-review-jest}/business-logic.md | 2 +- .../jest => .claude/skills/code-review-jest}/code-quality.md | 2 +- .../jest => .claude/skills/code-review-jest}/performance.md | 2 +- .claude/skills/code-review-jest/skill.md | 2 +- .../skills/code-review-react}/business-logic.md | 2 +- .../react => .claude/skills/code-review-react}/code-quality.md | 2 +- .../react => .claude/skills/code-review-react}/performance.md | 2 +- .claude/skills/code-review-react/skill.md | 2 +- .../common.md => .claude/skills/review-priority-and-format.md | 0 9 files changed, 8 insertions(+), 8 deletions(-) rename {.agents/review-checklists/jest => .claude/skills/code-review-jest}/business-logic.md (94%) rename {.agents/review-checklists/jest => .claude/skills/code-review-jest}/code-quality.md (98%) rename {.agents/review-checklists/jest => .claude/skills/code-review-jest}/performance.md (96%) rename {.agents/review-checklists/react => .claude/skills/code-review-react}/business-logic.md (98%) rename {.agents/review-checklists/react => .claude/skills/code-review-react}/code-quality.md (99%) rename {.agents/review-checklists/react => .claude/skills/code-review-react}/performance.md (96%) rename .agents/review-checklists/common.md => .claude/skills/review-priority-and-format.md (100%) diff --git a/.agents/review-checklists/jest/business-logic.md b/.claude/skills/code-review-jest/business-logic.md similarity index 94% rename from .agents/review-checklists/jest/business-logic.md rename to .claude/skills/code-review-jest/business-logic.md index 7c154b14bd..ac08fb0179 100644 --- a/.agents/review-checklists/jest/business-logic.md +++ b/.claude/skills/code-review-jest/business-logic.md @@ -1,6 +1,6 @@ # Business Logic -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## Jest tests must assert on meaningful outcomes diff --git a/.agents/review-checklists/jest/code-quality.md b/.claude/skills/code-review-jest/code-quality.md similarity index 98% rename from .agents/review-checklists/jest/code-quality.md rename to .claude/skills/code-review-jest/code-quality.md index bd6bee4574..facf3def4a 100644 --- a/.agents/review-checklists/jest/code-quality.md +++ b/.claude/skills/code-review-jest/code-quality.md @@ -1,6 +1,6 @@ # Code Quality -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## Arrange / Act / Assert (AAA) structure diff --git a/.agents/review-checklists/jest/performance.md b/.claude/skills/code-review-jest/performance.md similarity index 96% rename from .agents/review-checklists/jest/performance.md rename to .claude/skills/code-review-jest/performance.md index 67cd2af28e..8fb53929b1 100644 --- a/.agents/review-checklists/jest/performance.md +++ b/.claude/skills/code-review-jest/performance.md @@ -1,6 +1,6 @@ # Performance -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## No redundant or near-duplicate tests diff --git a/.claude/skills/code-review-jest/skill.md b/.claude/skills/code-review-jest/skill.md index c5dbfb1de7..7867d78ea9 100644 --- a/.claude/skills/code-review-jest/skill.md +++ b/.claude/skills/code-review-jest/skill.md @@ -18,7 +18,7 @@ Use this skill whenever the user asks to review Jest test code (especially `.tes Stick to the checklist below for every applicable file and mode. Apply only the Jest checklist rules to test files — do not apply React component rules to component code that happens to be visible via imports in the test file. ## Checklist -See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/jest/code-quality.md](../../../.agents/review-checklists/jest/code-quality.md), [.agents/review-checklists/jest/performance.md](../../../.agents/review-checklists/jest/performance.md), [.agents/review-checklists/jest/business-logic.md](../../../.agents/review-checklists/jest/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow. +See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow. Use the rule's `Urgency` to place findings in the "urgent issues" vs "suggestions" sections. diff --git a/.agents/review-checklists/react/business-logic.md b/.claude/skills/code-review-react/business-logic.md similarity index 98% rename from .agents/review-checklists/react/business-logic.md rename to .claude/skills/code-review-react/business-logic.md index ce4bfa4eb2..7b3c4e8f88 100644 --- a/.agents/review-checklists/react/business-logic.md +++ b/.claude/skills/code-review-react/business-logic.md @@ -1,6 +1,6 @@ # Rule Catalog — Business Logic -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## Avoid using array index as React key diff --git a/.agents/review-checklists/react/code-quality.md b/.claude/skills/code-review-react/code-quality.md similarity index 99% rename from .agents/review-checklists/react/code-quality.md rename to .claude/skills/code-review-react/code-quality.md index 82aea80b49..63433fe771 100644 --- a/.agents/review-checklists/react/code-quality.md +++ b/.claude/skills/code-review-react/code-quality.md @@ -1,6 +1,6 @@ # Rule Catalog — Code Quality -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## Props interface should be declared separately diff --git a/.agents/review-checklists/react/performance.md b/.claude/skills/code-review-react/performance.md similarity index 96% rename from .agents/review-checklists/react/performance.md rename to .claude/skills/code-review-react/performance.md index 572bec0c76..1c6b3471b5 100644 --- a/.agents/review-checklists/react/performance.md +++ b/.claude/skills/code-review-react/performance.md @@ -1,6 +1,6 @@ # Rule Catalog — Performance -> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist. +> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist. ## Inline object/array literals in JSX props diff --git a/.claude/skills/code-review-react/skill.md b/.claude/skills/code-review-react/skill.md index 5f9cc672b3..3860bd5efe 100644 --- a/.claude/skills/code-review-react/skill.md +++ b/.claude/skills/code-review-react/skill.md @@ -18,7 +18,7 @@ Use this skill whenever the user asks to review frontend code (especially `.tsx` Stick to the checklist below for every applicable file and mode. Apply only the React/frontend checklist rules — do not apply Jest test rules to test code that may be co-located or visible in the same file. ## Checklist -See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/react/code-quality.md](../../../.agents/review-checklists/react/code-quality.md), [.agents/review-checklists/react/performance.md](../../../.agents/review-checklists/react/performance.md), [.agents/review-checklists/react/business-logic.md](../../../.agents/review-checklists/react/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow. +See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow. Additionally, check for WCAG 2.2 Level AA accessibility violations using [wcag-22-checklist.md](../wcag-compliance/wcag-22-checklist.md). Use category **Accessibility** for these findings. Prioritize urgent WCAG criteria (missing alt text, keyboard traps, no focus indicators, missing form labels, broken ARIA) alongside Correctness-level issues. diff --git a/.agents/review-checklists/common.md b/.claude/skills/review-priority-and-format.md similarity index 100% rename from .agents/review-checklists/common.md rename to .claude/skills/review-priority-and-format.md