Skip to content

Commit 56d8a74

Browse files
authored
Dont trim the selection when recapitalizing (#2225)
1 parent 6ce9196 commit 56d8a74

7 files changed

Lines changed: 170 additions & 197 deletions

File tree

app/src/main/java/helium314/keyboard/keyboard/KeyboardSwitcher.java

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import android.widget.Toast;
2828

2929
import androidx.annotation.NonNull;
30+
import androidx.annotation.Nullable;
3031

3132
import helium314.keyboard.event.Event;
3233
import helium314.keyboard.keyboard.KeyboardLayoutSet.KeyboardLayoutSetException;
@@ -47,7 +48,7 @@
4748
import helium314.keyboard.latin.utils.KtxKt;
4849
import helium314.keyboard.latin.utils.LanguageOnSpacebarUtils;
4950
import helium314.keyboard.latin.utils.Log;
50-
import helium314.keyboard.latin.utils.RecapitalizeStatus;
51+
import helium314.keyboard.latin.utils.RecapitalizeMode;
5152
import helium314.keyboard.latin.utils.ResourceUtils;
5253
import helium314.keyboard.latin.utils.ScriptUtils;
5354
import helium314.keyboard.latin.utils.SubtypeUtilsAdditional;
@@ -139,7 +140,8 @@ private boolean updateKeyboardThemeAndContextThemeWrapper(final Context context,
139140
}
140141

141142
public void loadKeyboard(final EditorInfo editorInfo, final SettingsValues settingsValues,
142-
final int currentAutoCapsState, final int currentRecapitalizeState, KeyboardLayoutSet.InternalAction internalAction) {
143+
final int currentAutoCapsState, @Nullable final RecapitalizeMode currentRecapitalizeState,
144+
KeyboardLayoutSet.InternalAction internalAction) {
143145
final KeyboardLayoutSet.Builder builder = new KeyboardLayoutSet.Builder(
144146
mThemeContext, editorInfo);
145147
final int keyboardWidth = ResourceUtils.getKeyboardWidth(mThemeContext, settingsValues);
@@ -223,22 +225,22 @@ public Keyboard getKeyboard() {
223225
// TODO: Remove this method. Come up with a more comprehensive way to reset the keyboard layout
224226
// when a keyboard layout set doesn't get reloaded in LatinIME.onStartInputViewInternal().
225227
public void resetKeyboardStateToAlphabet(final int currentAutoCapsState,
226-
final int currentRecapitalizeState) {
228+
@Nullable final RecapitalizeMode currentRecapitalizeState) {
227229
mState.onResetKeyboardStateToAlphabet(currentAutoCapsState, currentRecapitalizeState);
228230
}
229231

230232
public void onPressKey(final int code, final boolean isSinglePointer,
231-
final int currentAutoCapsState, final int currentRecapitalizeState) {
233+
final int currentAutoCapsState, @Nullable final RecapitalizeMode currentRecapitalizeState) {
232234
mState.onPressKey(code, isSinglePointer, currentAutoCapsState, currentRecapitalizeState);
233235
}
234236

235237
public void onReleaseKey(final int code, final boolean withSliding,
236-
final int currentAutoCapsState, final int currentRecapitalizeState) {
238+
final int currentAutoCapsState, @Nullable final RecapitalizeMode currentRecapitalizeState) {
237239
mState.onReleaseKey(code, withSliding, currentAutoCapsState, currentRecapitalizeState);
238240
}
239241

240242
public void onFinishSlidingInput(final int currentAutoCapsState,
241-
final int currentRecapitalizeState) {
243+
@Nullable final RecapitalizeMode currentRecapitalizeState) {
242244
mState.onFinishSlidingInput(currentAutoCapsState, currentRecapitalizeState);
243245
}
244246

@@ -384,8 +386,8 @@ public void setNumpadKeyboard() {
384386
}
385387

386388
@Override
387-
public void toggleNumpad(final boolean withSliding, final int autoCapsFlags, final int recapitalizeMode,
388-
final boolean forceReturnToAlpha) {
389+
public void toggleNumpad(final boolean withSliding, final int autoCapsFlags,
390+
@Nullable final RecapitalizeMode recapitalizeMode, final boolean forceReturnToAlpha) {
389391
if (DEBUG_ACTION) {
390392
Log.d(TAG, "toggleNumpad");
391393
}
@@ -452,11 +454,11 @@ public void onToggleKeyboard(@NonNull final KeyboardSwitchState toggleState) {
452454

453455
// Future method for requesting an updating to the shift state.
454456
@Override
455-
public void requestUpdatingShiftState(final int autoCapsFlags, final int recapitalizeMode) {
457+
public void requestUpdatingShiftState(final int autoCapsFlags, @Nullable final RecapitalizeMode recapitalizeMode) {
456458
if (DEBUG_ACTION) {
457459
Log.d(TAG, "requestUpdatingShiftState: "
458460
+ " autoCapsFlags=" + CapsModeUtils.flagsToString(autoCapsFlags)
459-
+ " recapitalizeMode=" + RecapitalizeStatus.modeToString(recapitalizeMode));
461+
+ " recapitalizeMode=" + recapitalizeMode);
460462
}
461463
mState.onUpdateShiftState(autoCapsFlags, recapitalizeMode);
462464
}
@@ -598,7 +600,7 @@ public boolean isInDoubleTapShiftKeyTimeout() {
598600
* Updates state machine to figure out when to automatically switch back to the previous mode.
599601
*/
600602
public void onEvent(final Event event, final int currentAutoCapsState,
601-
final int currentRecapitalizeState) {
603+
@Nullable final RecapitalizeMode currentRecapitalizeState) {
602604
mState.onEvent(event, currentAutoCapsState, currentRecapitalizeState);
603605
}
604606

0 commit comments

Comments
 (0)