fix(Runtime): Use Node v14 (LLC-1483) (#846)

BREAKING CHANGE: Uses Node v14 instead of v12

Author: crazy-grizzly

.circleci/config.yml

@@ -7,7 +7,7 @@ machine:
 jobs:
   build:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
@@ -41,7 +41,7 @@ jobs:
           key: dist-{{ .Branch }}-{{ .Revision }}
   test-local:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
@@ -77,7 +77,7 @@ jobs:
       - run: yarn codecov
   test-s3:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
@@ -122,7 +122,7 @@ jobs:
       - run: yarn codecov
   test-azure:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
@@ -164,7 +164,7 @@ jobs:
       - run: yarn codecov
   test-google:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
@@ -204,7 +204,7 @@ jobs:
       - run: yarn codecov
   release:
     docker:
-      - image: node:12
+      - image: node:14
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:12
+FROM node:14
 ENV NPM_CONFIG_LOGLEVEL warn
 WORKDIR /usr/src/app
 

docker-compose.yml

@@ -1,9 +1,9 @@
 version: '3.6'
 services:
   mongo:
+    command: --bind_ip_all --replSet rs0
     container_name: ll_mongo
     image: mongo:4.4
-    command: --bind_ip_all --replSet rs0
     ports:
       - 27017:27017
     volumes:

src/apps/statements/expressPresenter/tests/getParts.test.ts

@@ -32,8 +32,8 @@ const partToTestPart = async (part: Part) => {
 const getTestParts = async (stream: ReadableStream, boundary: string) => {
   const actualParts = await getParts(stream, boundary);
   const testPartsPromises = actualParts.map(partToTestPart);
-  const testParts = await Promise.all(testPartsPromises);
-  return testParts;
+
+  return Promise.all(testPartsPromises);
 };
 
 const headersToString = (headers: { readonly [key: string]: string }): string => {
@@ -180,19 +180,28 @@ describe('expressPresenter/utils/getParts', () => {
 
   it('should throw error when there is an error in the stream', async () => {
     const stream = new ReadableStream();
-    const error = new Error();
-    try {
-      stream.push('hello');
-      stream.emit('error', error);
-    } catch {
-      // Do nothing.
-    }
+    stream._read = () => true;
+
+    const error = new Error('Test stream error');
+    const errorEmitDelayMs = 50;
+
     try {
-      await getTestParts(stream, TEST_BOUNDARY);
-      /* istanbul ignore next */
-      assert.fail('Expected error to be thrown.');
-    } catch {
-      // Do nothing.
+      await Promise.all([
+        getTestParts(stream, TEST_BOUNDARY),
+        new Promise<void>((resolve) => {
+          setTimeout(() => {
+            stream.emit('error', error);
+
+            resolve();
+          }, errorEmitDelayMs);
+        }),
+      ]);
+    } catch (e) {
+      assert.deepEqual(e, error);
+
+      return;
     }
+
+    assert.fail(`Error "${error.message}" should have thrown`);
   });
 });

src/apps/statements/utils/getStreamData.ts

@@ -21,6 +21,5 @@ export default async (stream: ReadableStream): Promise<string> => {
     });
   });
 
-  const trimmedData = trim(data, trimmedChars);
-  return trimmedData;
+  return trim(data, trimmedChars);
 };