Merge pull request #170 from Lemoncode/feature/fix-cache-reservoir-detail

update api

Author: brauliodiez

front/src/pods/embalse/api/embalse.api.ts

@@ -3,22 +3,39 @@ import { unstable_cache } from "next/cache";
 import type { ReservoirInfo } from "./embalse.api-model";
 import { contentIslandClient } from "@/lib";
 
+const fetchReservoirInfoBySlug = async (
+  slug: string
+): Promise<ReservoirInfo> => {
+  const result = await contentIslandClient.getContent<ReservoirInfo>({
+    language: "es",
+    "fields.slug": slug,
+  });
+
+  if (!result) {
+    throw new Error(`Empty reservoir info for slug: ${slug}`);
+  }
+
+  return result;
+};
+
+const fetchReservoirInfoBySlugCached = unstable_cache(
+  fetchReservoirInfoBySlug,
+  ["reservoir-by-slug"],
+  { revalidate: 60 }
+);
+
 /**
  * Cached version of getReservoirInfoBySlug.
  * Revalidates every 60 seconds.
+ * Only caches when data is available.
  */
-export const getReservoirInfoBySlugCached = unstable_cache(
-  async (slug: string): Promise<ReservoirInfo | null> => {
-    try {
-      return await contentIslandClient.getContent<ReservoirInfo>({
-        language: "es",
-        "fields.slug": slug,
-      });
-    } catch (error) {
-      console.warn(`Warning reservoir info for slug not available: ${slug}`);
-      return null;
-    }
-  },
-  ["reservoir-by-slug"],
-  { revalidate: 60 }, // Check timing at least 1 hour
-);
+export const getReservoirInfoBySlugCached = async (
+  slug: string
+): Promise<ReservoirInfo | null> => {
+  try {
+    return await fetchReservoirInfoBySlugCached(slug);
+  } catch (error) {
+    console.warn(`Warning reservoir info for slug not available: ${slug}`);
+    return null;
+  }
+};