Applying feedback

Removed css file.
Replaced `products` with `brands` in service.
Some minor changes.

Author: crsanti

samples/jquery/00 ShoppingForm/src/css/site.css

@@ -31,7 +31,7 @@ class App {
   }
 
   loadBrands() {
-    productsService.fetchProducts()
+    productsService.fetchBrands()
       .then(fetchedProducts => {
         this.brands = fetchedProducts;
         this.loadSelect($selBrands, this.brands);
@@ -75,15 +75,15 @@ class App {
     }
   }
 
-  loadProductsByBrand(id) {
-    if (id !== null) {
-      const osList = this.getProductsByBrand(id);
-      this.loadSelect($selProducts, osList);
+  loadProductsByBrand(brand) {
+    if (brand !== null) {
+      const products = this.getProductsByBrand(brand);
+      this.loadSelect($selProducts, products);
     }
   }
 
   getProductsByBrand(id) {
-    const brand = this.brands.filter(product => product.id === id);
+    const brand = this.brands.filter(brand => brand.id === id);
     return brand[0] && brand[0].products;
   }
 
@@ -107,24 +107,26 @@ class App {
   getModel($form) {
     return $form
       .serializeArray()
+
       // from { name: <prop>, value: <val> } to [<prop>, <val>] }
       .map(field => ({ [field.name]: field.value }))
+
       // reduce all in an object
       .reduce((vm, field) => ({ ...vm, ...field }), {});
-  };
+  }
 
   handleFieldValidationResult($form) {
-    return (function (fieldValidationResult) {
+    return (fieldValidationResult) => {
       const field = $form.get(0)[fieldValidationResult.key];
       this.toggleErrorMessage(fieldValidationResult, $(field));
-    }).bind(this);
+    };
   }
 
   onFieldChange(event) {
     const $field = $(event.currentTarget);
     productsFormValidation
       .validateField(null, $field.attr('name'), $field.val(), { onChange: true })
-      .then((validationResult) => {
+      .then(validationResult => {
         this.toggleErrorMessage(validationResult, $field);
       })
       .catch(error => {
@@ -148,5 +150,5 @@ class App {
 }
 
 export {
-  App,
+  App
 };

samples/jquery/00 ShoppingForm/src/modules/app/app.js

@@ -28,10 +28,7 @@ function validateNif(value) {
       .replace(/^[Z]/, '2');
     const letter = valueToUpper.substr(-1);
     const charIndex = parseInt(nie.substr(0, 8)) % 23;
-
-    if (validChars.charAt(charIndex) === letter) {
-      isValid = true;
-    }
+    isValid = (validChars.charAt(charIndex) === letter);
   }
 
   return isValid;

samples/jquery/00 ShoppingForm/src/modules/app/validation/rules/nifValidator.js

@@ -1,4 +1,4 @@
-const products = [
+const brands = [
   {
     id: 18,
     description: 'Corsair',
@@ -59,10 +59,10 @@ const products = [
   },
 ];
 
-function fetchProducts() {
-  return Promise.resolve(products);
+function fetchBrands() {
+  return Promise.resolve(brands);
 }
 
 export const productsService = {
-  fetchProducts,
+  fetchBrands,
 };