Skip to content

Commit 36ce9d5

Browse files
committed
Removed old TODOS
1 parent 902d8ca commit 36ce9d5

5 files changed

Lines changed: 1 addition & 9 deletions

File tree

lib/src/spec/validationEngine.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { ValidationEngine } from '../validationEngine';
22
import { FieldValidationResult } from '../entities';
33

4-
//TODO: Implement Issue #20
54
describe('ValidationEngine tests', () => {
65
it('should return isFormPristine true after initialization', () => {
76
// Arrange

lib/src/spec/validationEngineValidateForm.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { ValidationEngine } from '../validationEngine';
22
import { FieldValidationResult, FormValidationResult } from '../entities';
33
import { consts } from '../consts';
44

5-
//TODO: Implement Issue #20
65
describe('ValidationEngine Validate Form', () => {
76
describe('Group #1 => When calling validateForm and addFieldValidation', () => {
87
it('Spec #1 => should return a failed FormValidationResult with one fieldErrors equals ' +

lib/src/spec/validationEngineValidateSingleField.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { ValidationEngine } from '../validationEngine';
22
import { FieldValidationResult } from '../entities';
33

4-
//TODO: Implement Issue #20 (Take into account if it returns Promise.resolve(undefined))
54
describe('lcFormValidation simple form', () => {
65
it('should return isValidationInProgress true if validations are inProgress', (done) => {
76
// Arrange

lib/src/validationEngine.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export interface IValidationEngine {
1818
isValidationInProgress(): boolean;
1919
validateForm(vm: any): Promise<FormValidationResult>;
2020
validateField(vm: any, key: string, value: any, eventsFilter?: ValidationEventsFilter): Promise<FieldValidationResult>;
21-
// TODO: Implement Issue #15
2221
addFieldValidation(key: string, validation: FieldValidationFunction, eventsFilter?: ValidationEventsFilter): void;
2322
addFormValidation(validation: FormValidationFunction): void;
2423
isValidationInProgress(): boolean;
@@ -61,8 +60,6 @@ export class ValidationEngine implements IValidationEngine {
6160
fieldValidationResults = [...fieldValidationResults, ...this.validateGlobalFormValidations(viewModel)];
6261
}
6362

64-
// TODO: Implement Issue #16 - Error handling
65-
6663
// Once all the single field validations have been resolved
6764
// resolve the fullFormValidatePromise
6865
Promise.all(fieldValidationResults)
@@ -108,7 +105,7 @@ export class ValidationEngine implements IValidationEngine {
108105
this.asyncValidationInProgressCount++;
109106

110107
const fieldValidationResultPromise = new Promise((resolve, reject) => {
111-
// TODO: this should be encapsulated into two separate functions, Issue #26
108+
// TODO: this should be encapsulated into two separate functions
112109
if (!this.isFieldKeyMappingDefined(key)) {
113110
this.asyncValidationInProgressCount--;
114111
resolve();

samples/react/00 SimpleForm/src/components/sampleForm/validations/customerFormValidation.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import {
55
RequiredParams,
66
} from 'lc-form-validation';
77

8-
// TODO: Implement Issue #17
9-
// TODO: Implement Issue #6
108
const customerValidationConstraints: ValidationConstraints = {
119
fields: {
1210
fullname: [

0 commit comments

Comments
 (0)