Improve some samples

Author: crsanti

samples/react/01 SignupForm/src/components/sampleSignupForm/validations/signupFormValidation.ts

@@ -47,25 +47,18 @@ function resolveLoginExists(loginExists: boolean): Promise<FieldValidationResult
 
 interface lengthConstraintParams {
   minLength: number;
-  maxLength: number;
 }
 const lengthConstraint: lengthConstraintParams = {
-  minLength: 4,
-  maxLength: 10
+  minLength: 4
 };
 const minLengthValidationHandler: FieldValidationFunction = (password: string, vm, customParams: lengthConstraintParams) => {
-  const { minLength, maxLength } = customParams;
+  const { minLength } = customParams;
   const isValidMinLength = password.length >= minLength;
-  const isValidMaxLength = password.length <= maxLength;
   const minLengthErrorMessage = `Minimum ${minLength} characters required`;
-  const maxLengthErrorMessage = `Maximum ${maxLength} characters length`;
-  let errorMessage = isValidMaxLength
-    ? isValidMinLength ? '' : minLengthErrorMessage
-    : maxLengthErrorMessage;
-
+  const errorMessage = isValidMinLength ? '' : minLengthErrorMessage;
   const fieldValidationResult: FieldValidationResult = new FieldValidationResult();
   fieldValidationResult.type = 'PASSWORD_LENGTH';
-  fieldValidationResult.succeeded = isValidMinLength && isValidMaxLength;
+  fieldValidationResult.succeeded = isValidMinLength;
   fieldValidationResult.errorMessage = errorMessage;
   return Promise.resolve(fieldValidationResult);
 };

samples/react/02 QuizForm/src/actions/quizResolveCompleted.ts

@@ -10,5 +10,5 @@ export const quizResolveCompleted = (formValidationResult: FormValidationResult)
   return {
     type: actionsDef.quiz.QUIZ_RESOLVE_COMPLETED,
     formValidationResult
-  }
+  };
 }

samples/react/02 QuizForm/src/components/quizForm/quizForm.container.ts

@@ -5,15 +5,15 @@ import { QuizEntity } from '../../entity/quizEntity';
 import { quizResolveStart } from '../../actions/quizResolveStart';
 import { resetQuizResolveCompleted } from '../../actions/resetQuizResolveCompleted';
 
-let mapStateToProps = (state) => {
+const mapStateToProps = (state) => {
   return {
     quiz: state.quiz.quiz,
     quizResult: state.quiz.quizResult,
     quizResolveCompleted: state.quiz.quizResolveCompleted
   }
-}
+};
 
-let mapDispatchToProps = (dispatch) => {
+const mapDispatchToProps = (dispatch) => {
   return {
     onSelectedQuestionHandler: (questionId: string, value: boolean) => {
       return dispatch(quizUIInputCompleted(questionId, value));
@@ -25,9 +25,9 @@ let mapDispatchToProps = (dispatch) => {
       return dispatch(resetQuizResolveCompleted());
     }
   }
-}
+};
 
 export let ContainerQuizForm = connect(
   mapStateToProps,
   mapDispatchToProps
-)(QuizForm)
+)(QuizForm);