Changed method names in validationEngine

Author: crsanti

lib/src/baseFormValidation.ts

@@ -73,7 +73,7 @@ export class BaseFormValidation implements FormValidation {
   }
 
   validateField(vm: any, key: string, value: any, eventsFilter?: ValidationEventsFilter): Promise<FieldValidationResult> {
-    return this.validationEngine.triggerFieldValidation(vm, key, value, eventsFilter);
+    return this.validationEngine.validateField(vm, key, value, eventsFilter);
   }
 
   validateForm(vm: any): Promise<FormValidationResult> {

lib/src/spec/baseFormValidation.spec.ts

@@ -34,10 +34,10 @@ describe('formValidation tests', () => {
       expect(isFormDirty.calledOnce).to.be.true;
     }));
 
-    it('Spec#3 => should have an exposed method "validateField" that calls ValidationEngine.validateSingleField', sinon.test(function () {
+    it('Spec#3 => should have an exposed method "validateField" that calls ValidationEngine.fireFieldValidations', sinon.test(function () {
       // Arrange
       const sinon: sinon.SinonStatic = this;
-      const validateSingleField = sinon.stub(ValidationEngine.prototype, 'validateSingleField', () => { });
+      const fireFieldValidations = sinon.stub(ValidationEngine.prototype, 'fireFieldValidations', () => { });
       const validationConstraints = {};
       const viewModel = {};
       const key = 'fullname';
@@ -49,7 +49,7 @@ describe('formValidation tests', () => {
       formValidation.validateField(viewModel, key, value, eventsFilter);
 
       // Assert
-      expect(validateSingleField.calledOnce).to.be.true;
+      expect(fireFieldValidations.calledOnce).to.be.true;
     }));
 
     it('Spec#4 => should have an exposed method "validateForm" that calls ValidationEngine.validateForm', sinon.test(function () {

lib/src/spec/validationEngine.spec.ts

@@ -17,7 +17,7 @@ describe('ValidationEngine tests', () => {
     const viewModel = [{ formFieldName: 'nameId', vmFieldName: 'name' }];
 
     formValidationBase
-      .triggerFieldValidation(viewModel, 'nameId', 'newContent')
+      .validateField(viewModel, 'nameId', 'newContent')
       .then((errors) => {
         // Assert
         expect(formValidationBase.isFormPristine()).to.be.false;
@@ -39,7 +39,7 @@ describe('ValidationEngine tests', () => {
     const viewModel = [{ formFieldName: 'nameId', vmFieldName: 'name' }];
 
     formValidationBase
-      .triggerFieldValidation(viewModel, 'nameId', 'newContent')
+      .validateField(viewModel, 'nameId', 'newContent')
       .then((errors) => {
         // Assert
         expect(formValidationBase.isFormDirty()).to.be.true;
@@ -62,7 +62,7 @@ describe('ValidationEngine tests', () => {
 
     // Act
     formValidationBase
-      .triggerFieldValidation(viewModel, 'nameId', 'newContent')
+      .validateField(viewModel, 'nameId', 'newContent')
       .then((errors) => {
         // Assert
         expect(formValidationBase.isValidationInProgress()).to.be.false;

lib/src/spec/validationEngineValidateSingleField.spec.ts

@@ -28,7 +28,7 @@ describe('lcFormValidation simple form', () => {
     );
 
     formValidationBase
-      .triggerFieldValidation(viewModel, 'fullname', 'newContent')
+      .validateField(viewModel, 'fullname', 'newContent')
       .then((errors) => {
         // Assert
         expect(formValidationBase.isValidationInProgress()).to.be.false;
@@ -66,7 +66,7 @@ describe('lcFormValidation simple form', () => {
       );
 
       formValidationBase
-        .triggerFieldValidation(viewModel, 'fullname', '')
+        .validateField(viewModel, 'fullname', '')
         .then((fieldValidationResult: FieldValidationResult) => {
           // Assert
           expect(fieldValidationResult.key).to.be.equal('fullname');
@@ -103,7 +103,7 @@ describe('lcFormValidation simple form', () => {
       );
 
       formValidationBase
-        .triggerFieldValidation(viewModel, 'fullname', 'john')
+        .validateField(viewModel, 'fullname', 'john')
         .then((fieldValidationResult: FieldValidationResult) => {
 
           // Assert
@@ -128,7 +128,7 @@ describe('lcFormValidation simple form', () => {
       }
     );
 
-    const promise = formValidationBase.triggerFieldValidation(viewModel, 'fullname', '');
+    const promise = formValidationBase.validateField(viewModel, 'fullname', '');
 
     //Assert
     expect(promise).to.eventually.be.rejected.and.notify(done);

lib/src/validationEngine.ts

@@ -17,7 +17,7 @@ export interface IValidationEngine {
   isFormPristine(): boolean;
   isValidationInProgress(): boolean;
   validateForm(vm: any): Promise<FormValidationResult>;
-  triggerFieldValidation(vm: any, key: string, value: any, eventsFilter?: ValidationEventsFilter): Promise<FieldValidationResult>;
+  validateField(vm: any, key: string, value: any, eventsFilter?: ValidationEventsFilter): Promise<FieldValidationResult>;
   // TODO: Implement Issue #15
   addFieldValidation(key: string, validation: FieldValidationFunction, eventsFilter?: ValidationEventsFilter): void;
   addFormValidation(validation: FormValidationFunction): void;
@@ -53,7 +53,7 @@ export class ValidationEngine implements IValidationEngine {
       let fieldValidationResults: ValidationResult[] = validationsDispatcher.fireAllFieldsValidations(
         viewModel,
         Object.keys(this.validationsPerField),
-        this.validateSingleField.bind(this)
+        this.fireFieldValidations.bind(this)
       );
 
       // Let's add GlobalFormValidations
@@ -97,14 +97,14 @@ export class ValidationEngine implements IValidationEngine {
     return globalFieldResultValidations;
   }
 
-  triggerFieldValidation(vm: any, key: string, value: any, filters: ValidationEventsFilter = consts.defaultFilter): Promise<FieldValidationResult> {
+  validateField(vm: any, key: string, value: any, filters: ValidationEventsFilter = consts.defaultFilter): Promise<FieldValidationResult> {
     // updated dirty flag and perform validation
     this.isFormChanged = false;
-    return this.validateSingleField(vm, key, value, filters);
+    return this.fireFieldValidations(vm, key, value, filters);
   }
 
   // if filter is null all validations are returned (fullform validation case)
-  private validateSingleField(vm: any, key: string, value: any, filters: ValidationEventsFilter = null): Promise<FieldValidationResult> {
+  private fireFieldValidations(vm: any, key: string, value: any, filters: ValidationEventsFilter = null): Promise<FieldValidationResult> {
     this.asyncValidationInProgressCount++;
 
     const fieldValidationResultPromise = new Promise((resolve, reject) => {