Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

compare_builds returns message instead of variable for an unfinished build #108

Description

@jscook2345

compare_builds is expected to return a dict, however when one of the builds is not finished, you get the following:

['Cannot report regressions/fixes on a non-finished builds']

I'm not sure this is correct behavior. Perhaps it should return something else (none?) and squad-client can throw an exception letting me know that it cannot work on unfinished builds

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions