Adding warning on shadow variables for gcc / clang and starting to replace the tmpnam with c++ 17 features for our tests to remove the warnings

Author: LinuxDevon

.github/workflows/pipeline.yml

@@ -57,7 +57,7 @@ jobs:
 
       - name: Build tests + lib
         working-directory: ${{runner.workspace}}
-        run: cmake --build build
+        run: cmake --build build --parallel `nproc`
 
       - name: Run tests
         env:

CMakeLists.txt

@@ -65,7 +65,7 @@ endif()
 
 list(APPEND GCC_CLANG_COMPILE_FLAGS
     -Wall -Wextra -Wpedantic
-    -Wconversion -Wint-in-bool-context
+    -Wconversion -Wint-in-bool-context -Wshadow
     -Wmissing-declarations -Wmissing-field-initializers
     -Werror
 )

test/CMakeLists.txt

@@ -10,6 +10,9 @@ FetchContent_Declare(
 FetchContent_MakeAvailable(Catch2)
 include(Catch)
 
+# Need filesystem for testing
+set(CMAKE_CXX_STANDARD 17)
+
 if (MSVC)
     add_compile_options(/W4 /WX)
 else()

test/common.cpp

@@ -1,5 +1,8 @@
 #include "common.hpp"
 #include "defines.hpp"
+#include <filesystem>
+#include <fstream>
+#include <iostream>
 
 bool create_tmp_dbc_with(const char* filename, const char* content) {
 	auto* file = std::fopen(filename, "w");
@@ -12,3 +15,18 @@ bool create_tmp_dbc_with(const char* filename, const char* content) {
 	std::fclose(file);
 	return true;
 }
+
+std::string create_temporary_dbc_with(const char* contents) {
+	std::filesystem::path temp_dir = std::filesystem::temp_directory_path();
+
+	// Generate a unique temporary file name
+	std::filesystem::path temp_file = temp_dir / "temp_file_XXXXXX"; // "XXXXXX" is a placeholder for a unique name
+
+	std::ofstream file(temp_file);
+	if (file.is_open()) {
+		file << contents << std::endl;
+		file.close();
+	}
+
+	return temp_file;
+}

test/common.hpp

@@ -1,6 +1,9 @@
 #ifndef COMMON_H
 #define COMMON_H
 
+#include <string>
+
 bool create_tmp_dbc_with(const char* filename, const char* content);
+std::string create_temporary_dbc_with(const char* contents);
 
 #endif // COMMON_H

test/test_dbc.cpp

@@ -63,22 +63,13 @@ TEST_CASE("Testing dbc file loading", "[fileio]") {
 }
 
 TEST_CASE("Testing  big endian, little endian") {
-	const auto* filename = std::tmpnam(NULL);
-
-	auto* file = std::fopen(filename, "w");
-	CHECK(file);
-
-	std::fputs(PRIMITIVE_DBC.c_str(), file);
-	// first big endian
-	// second little endian
-	std::fputs(R"(BO_ 234 MSG1: 8 Vector__XXX
+	std::string dbc_contents = PRIMITIVE_DBC + R"(BO_ 234 MSG1: 8 Vector__XXX
  SG_ Sig1 : 55|16@0- (0.1,0) [-3276.8|-3276.7] "C" Vector__XXX
- SG_ Sig2 : 39|16@1- (0.1,0) [-3276.8|-3276.7] "C" Vector__XXX)",
-			   file);
-	std::fclose(file);
+ SG_ Sig2 : 39|16@1- (0.1,0) [-3276.8|-3276.7] "C" Vector__XXX)";
+	const auto filename = create_temporary_dbc_with(dbc_contents.c_str());
 
 	auto parser = libdbc::DbcParser();
-	parser.parse_file(filename);
+	parser.parse_file(filename.c_str());
 
 	REQUIRE(parser.get_messages().size() == 1);
 	REQUIRE(parser.get_messages().at(0).name() == "MSG1");