Do not use reference, because then livetime must be considered

Murmele · Murmele · commit 12ae90fba638 · 2023-04-30T19:21:00.000+02:00
diff --git a/include/libdbc/message.hpp b/include/libdbc/message.hpp
@@ -29,7 +29,7 @@ struct Message {
 	ParseSignalsStatus parseSignals(const std::vector<uint8_t>& data, std::vector<double>& values) const;
 
 	void appendSignal(const Signal& signal);
-	const std::vector<Signal>& getSignals() const;
+	const std::vector<Signal> getSignals() const;
 	uint32_t id() const;
 	void addValueDescription(const std::string& signal_name, const std::vector<Signal::SignalValueDescriptions>&);
 
diff --git a/src/message.cpp b/src/message.cpp
@@ -67,7 +67,7 @@ void Message::appendSignal(const Signal& signal) {
 	m_signals.push_back(signal);
 }
 
-const std::vector<Signal>& Message::getSignals() const {
+const std::vector<Signal> Message::getSignals() const {
 	return m_signals;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ void Message::appendSignal(const Signal& signal) {`
`67`	`67`	`m_signals.push_back(signal);`
`68`	`68`	`}`
`69`	`69`
`70`		`-const std::vector<Signal>& Message::getSignals() const {`
	`70`	`+const std::vector<Signal> Message::getSignals() const {`
`71`	`71`	`return m_signals;`
`72`	`72`	`}`
`73`	`73`