Skip to content

Commit 67648ce

Browse files
committed
Fixed broken const-correctness in dbc.hpp and dbc.cpp.
1 parent 887d779 commit 67648ce

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

include/libdbc/dbc.hpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ class DbcParser : public Parser {
2727
void parse_file(const std::string& file_name) override;
2828
void parse_file(std::istream& stream) override;
2929

30-
std::string get_version() const;
31-
std::vector<std::string> get_nodes() const;
32-
std::vector<Libdbc::Message> get_messages() const;
30+
const std::string& get_version() const;
31+
const std::vector<std::string>& get_nodes() const;
32+
const std::vector<Libdbc::Message>& get_messages() const;
3333

3434
Message::ParseSignalsStatus parse_message(uint32_t message_id, const std::vector<uint8_t>& data, std::vector<double>& out_values);
3535

36-
std::vector<std::string> unused_lines() const;
36+
const std::vector<std::string>& unused_lines() const;
3737

3838
private:
39-
std::string version;
40-
std::vector<std::string> nodes;
41-
std::vector<Libdbc::Message> messages;
39+
std::string version{};
40+
std::vector<std::string> nodes{};
41+
std::vector<Libdbc::Message> messages{};
4242

4343
std::regex version_re;
4444
std::regex bit_timing_re;
@@ -48,7 +48,7 @@ class DbcParser : public Parser {
4848
std::regex value_re;
4949
std::regex signal_re;
5050

51-
std::vector<std::string> missed_lines;
51+
std::vector<std::string> missed_lines{};
5252

5353
void parse_dbc_header(std::istream& file_stream);
5454
void parse_dbc_nodes(std::istream& file_stream);

src/dbc.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,15 @@ std::string DbcParser::get_extension(const std::string& file_name) {
107107
return "";
108108
}
109109

110-
std::string DbcParser::get_version() const {
110+
const std::string& DbcParser::get_version() const {
111111
return version;
112112
}
113113

114-
std::vector<std::string> DbcParser::get_nodes() const {
114+
const std::vector<std::string>& DbcParser::get_nodes() const {
115115
return nodes;
116116
}
117117

118-
std::vector<Libdbc::Message> DbcParser::get_messages() const {
118+
const std::vector<Libdbc::Message>& DbcParser::get_messages() const {
119119
return messages;
120120
}
121121

@@ -246,7 +246,7 @@ void DbcParser::parse_dbc_messages(const std::vector<std::string>& lines) {
246246
}
247247
}
248248

249-
std::vector<std::string> DbcParser::unused_lines() const {
249+
const std::vector<std::string>& DbcParser::unused_lines() const {
250250
return missed_lines;
251251
}
252252

0 commit comments

Comments
 (0)