Remove the old temporary file function and removing the last instance of tmpnam with a time / random generator solution

Author: LinuxDevon

test/common.cpp

@@ -1,31 +1,36 @@
 #include "common.hpp"
 #include "defines.hpp"
-#include <exception>
+#include <chrono>
 #include <filesystem>
 #include <fstream>
 #include <iostream>
+#include <random>
 #include <stdexcept>
 
-bool create_tmp_dbc_with(const char* filename, const char* content) {
-	auto* file = std::fopen(filename, "w");
-	if (!file) {
-		return false;
-	}
+// Don't want to use tmpnam due to warnings. So here is an alternative using time and random numbers.
+// This should be platform agnostic as well.
+static std::string generate_unique_filename();
+std::string generate_unique_filename() {
+	// Get current time since epoch
+	auto now = std::chrono::system_clock::now();
+	auto duration = now.time_since_epoch();
+	auto milliseconds = std::chrono::duration_cast<std::chrono::milliseconds>(duration).count();
+
+	// Generate a random number
+	std::random_device rd;
+	std::mt19937 gen(rd());
+	std::uniform_int_distribution<> dis(0, 9999);
+	int random_num = dis(gen);
 
-	std::fputs(PRIMITIVE_DBC.c_str(), file);
-	std::fputs(content, file);
-	std::fclose(file);
-	return true;
+	// Concatenate time and random number to create a unique filename
+	return "temp_file_" + std::to_string(milliseconds) + "_" + std::to_string(random_num) + ".txt";
 }
 
 std::string create_temporary_dbc_with(const char* contents) {
 	std::filesystem::path temp_dir = std::filesystem::temp_directory_path();
 
 	// Generate a unique temporary file name
-	char filename[] = "temp_file_XXXXXX";
-	if (std::tmpnam(filename) == nullptr) {
-		throw std::runtime_error("Failed to generate a unique temporary filename.");
-	}
+	std::string filename = generate_unique_filename();
 	std::filesystem::path temp_file = temp_dir / filename;
 
 	std::ofstream file(temp_file);

test/common.hpp

@@ -3,7 +3,6 @@
 
 #include <string>
 
-bool create_tmp_dbc_with(const char* filename, const char* content);
 std::string create_temporary_dbc_with(const char* contents);
 
 #endif // COMMON_H