None of the e2e-spec.ts files actually require real GitHub OAuth credentials, making CI's GITHUB_CLIENT_ID/SECRET gate unnecessary

[chonilius]

Beyond the gate being unmet (filed separately), it's also the wrong gate: grepping test/*.e2e-spec.ts for GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET, GithubAuthGuard, or any HTTP-mocking library (nock and similar aren't dependencies at all) returns nothing. Every e2e spec (app.e2e-spec.ts, users.e2e-spec.ts, escrow-idempotency.e2e-spec.ts, the three stellar-address-validation-*.e2e-spec.ts files) builds its TestingModule from specific controllers/services with mocked providers and overrideGuard(...)-stubbed auth guards — none of them drive a real passport-github2 OAuth handshake, which is the only thing GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET are used for (GithubStrategy's constructor). The CI condition should very likely be checking DATABASE_URL reachability (already provided via the postgres service container) rather than GitHub OAuth credentials — as written, it can never actually run the e2e suite in this repository's CI unless someone adds credentials the tests don't need.

[vijay11149]

@vijay11149 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

i will love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @vijay11149 to this issue.

[stevengrams]

@stevengrams has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’d like to work on this issue. I’ve reviewed the expected behavior and believe I can provide an implementation that addresses the problem properly.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @stevengrams to this issue.

[qa-eden]

@qa-eden has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

maintainer, please assign this to me. I’ll audit the e2e setup, remove the unnecessary GitHub OAuth gate, and update CI to validate the actual dependencies required by the tests.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @qa-eden to this issue.

[femiolutayo]

@femiolutayo has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer. I will love to work on this issue. Please, assign to me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @femiolutayo to this issue.

[dollfins]

@dollfins has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I'd like to work on this. I can remove the unnecessary GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET checks from the CI workflow and update the e2e gate to verify DATABASE_URL reachability against the Postgres service container instead.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @dollfins to this issue.

[Skype-F]

@Skype-F has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

i have reviewed the issues i can work on this kindly assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Skype-F to this issue.

[bade2brazy]

@bade2brazy has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

assign this issue to me maintainer. i am sure i can handle it. Thank you very much.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bade2brazy to this issue.

[drips-wave]

Congratulations, @bade2brazy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @bade2brazy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊