team-split.util.ts's validateSplitPercentages and escrow.service.ts's assertValidSplits independently reimplement near-identical split-percentage validation

[chonilius]

src/teams/team-split.util.ts's validateSplitPercentages() and src/escrow/escrow.service.ts's private assertValidSplits() both exist to answer the same question — "does this list of recipient percentages sum to 100, with no non-positive entries" — for the two places this codebase collects percentage-based splits (CreateTeamDto.members and SplitReleaseDto.recipients). They're implemented completely independently rather than sharing one utility:

• Both reject an empty list.
• Both sum percentages and reject if Math.abs(total - 100) > 0.01.
• Both reject non-positive individual percentages.
• validateSplitPercentages additionally rejects percentage > 100 per-entry; assertValidSplits doesn't bother, because SplitRecipientDto.percentage already has @Max(100) — but TeamMemberSplitDto.percentage doesn't have an equivalent @Max() (already tracked separately), so the one place this duplication isn't purely cosmetic is exactly the one place the two implementations diverge in strictness.

Consolidating into one shared validator (in src/common/, alongside money.validator.ts/stellar-address.validator.ts) would remove the duplication and make the two DTOs' validation strictness consistent by construction rather than by two authors remembering to keep them in sync.

[ghzhost]

Resolved by PR #180

[Genesis000001]

@Genesis000001 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Assign this issue to me I have worked on something similar

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Genesis000001 to this issue.

[bade2brazy]

@bade2brazy has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

assign this issue to me maintainer. i am sure i can handle it. Thank you very much.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bade2brazy to this issue.

[drips-wave]

Congratulations, @bade2brazy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @bade2brazy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊