From bb6a611391cfe82b7f8530323d90b281c1db4ee4 Mon Sep 17 00:00:00 2001 From: Richard Kello Date: Tue, 14 Jul 2026 16:24:54 +0200 Subject: [PATCH 1/2] Fix private layers being displayed in record layers dropdown --- app/activeproject.cpp | 10 ++++++++++ app/recordinglayersproxymodel.cpp | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/app/activeproject.cpp b/app/activeproject.cpp index 78d786a9e..5d7a9b421 100644 --- a/app/activeproject.cpp +++ b/app/activeproject.cpp @@ -608,6 +608,16 @@ bool ActiveProject::recordingAllowed( QgsMapLayer *layer ) const if ( layer->readOnly() ) return false; + if ( layer ) + { + bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private; + + if ( isPrivate ) + { + return false; + } + } + return QgsMapLayerProxyModel::layerMatchesFilters( layer, Qgis::LayerFilter::HasGeometry | Qgis::LayerFilter::WritableLayer ) && layer->id() != positionTrackingLayerId() && layer->id() != mapSketchesLayerId(); } diff --git a/app/recordinglayersproxymodel.cpp b/app/recordinglayersproxymodel.cpp index 1ad1ed328..ab74ce973 100644 --- a/app/recordinglayersproxymodel.cpp +++ b/app/recordinglayersproxymodel.cpp @@ -31,6 +31,16 @@ bool RecordingLayersProxyModel::filterAcceptsRow( int source_row, const QModelIn QModelIndex index = mModel->index( source_row, 0, source_parent ); QgsMapLayer *layer = mModel->layerFromIndex( index ); + if ( layer ) + { + bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private; + + if ( isPrivate ) + { + return false; + } + } + return mModel->data( index, LayersModel::LayerVisible ).toBool(); } From 2081faf9e5f6185b430e8f81aeba137aa28f0c4e Mon Sep 17 00:00:00 2001 From: Richard Kello Date: Tue, 14 Jul 2026 17:09:04 +0200 Subject: [PATCH 2/2] Fix formating --- app/recordinglayersproxymodel.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/recordinglayersproxymodel.cpp b/app/recordinglayersproxymodel.cpp index ab74ce973..801128596 100644 --- a/app/recordinglayersproxymodel.cpp +++ b/app/recordinglayersproxymodel.cpp @@ -32,14 +32,14 @@ bool RecordingLayersProxyModel::filterAcceptsRow( int source_row, const QModelIn QgsMapLayer *layer = mModel->layerFromIndex( index ); if ( layer ) - { - bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private; + { + bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private; - if ( isPrivate ) - { - return false; - } + if ( isPrivate ) + { + return false; } + } return mModel->data( index, LayersModel::LayerVisible ).toBool(); }