From 33ecef71f309d7ca5e4a83c96baa06ff24ce1322 Mon Sep 17 00:00:00 2001 From: Ummi-001 Date: Mon, 24 Aug 2026 12:59:25 +0100 Subject: [PATCH] fix(app): remove duplicate ProgressModule registration in AppModule ProgressModule was listed twice in AppModule.imports (once among the feature modules and again after BlockchainModule). NestJS deduplicates modules internally so this was not fatal, but it misled readers auditing module wiring and wasted reviewer cycles. - Keep the single registration next to the other feature modules - Alphabetize the static imports array so future duplicates stand out; forRoot/registerAsync configuration blocks keep their logical order --- backend/src/app.module.ts | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/backend/src/app.module.ts b/backend/src/app.module.ts index 2f0e824..2a9b1d4 100644 --- a/backend/src/app.module.ts +++ b/backend/src/app.module.ts @@ -91,18 +91,20 @@ import { GameSessionsModule } from './game-sessions/game-sessions.module'; }; }, }), - AuthModule, - UsersModule, AnalyticsModule, - PuzzlesModule, + AuthModule, + BlockchainModule, + CategoriesModule, + ChallengeAttemptModule, + CommonModule, + GameSessionsModule, + HealthModule, ProgressModule, + PuzzlesModule, QuestsModule, - StreakModule, - CommonModule, RedisModule, - BlockchainModule, - ProgressModule, - CategoriesModule, + StreakModule, + UsersModule, // Register the custom JWT Auth Middleware module JwtAuthModule.registerAsync({ imports: [ConfigModule, UsersModule, RedisModule], @@ -120,9 +122,6 @@ import { GameSessionsModule } from './game-sessions/game-sessions.module'; publicRoutes: ['/auth', '/api', '/docs', '/health'], }), }), - HealthModule, - ChallengeAttemptModule, - GameSessionsModule, ], controllers: [AppController], providers: [AppService],