Address comments

Author: wildjames

packages/cdkConstructs/src/config/index.ts

@@ -5,7 +5,7 @@ import {StandardStackProps} from "../apps/createApp"
 export function getConfigFromEnvVar(
   varName: string,
   prefix: string = "CDK_CONFIG_",
-  defaultValue: string | undefined = undefined
+  defaultValue: string | undefined
 ): string {
   const value = process.env[prefix + varName]
   if (!value) {
@@ -20,7 +20,7 @@ export function getConfigFromEnvVar(
 export function getBooleanConfigFromEnvVar(
   varName: string,
   prefix: string = "CDK_CONFIG_",
-  defaultValue: string | undefined = undefined
+  defaultValue: string | undefined
 ): boolean {
   const value = getConfigFromEnvVar(varName, prefix, defaultValue)
   return value.toLowerCase().trim() === "true"
@@ -29,7 +29,7 @@ export function getBooleanConfigFromEnvVar(
 export function getNumberConfigFromEnvVar(
   varName: string,
   prefix: string = "CDK_CONFIG_",
-  defaultValue: string | undefined = undefined
+  defaultValue: string | undefined
 ): number {
   const value = getConfigFromEnvVar(varName, prefix, defaultValue)
   return Number(value)

packages/cdkConstructs/src/constructs/SsmParametersConstruct.ts

@@ -105,7 +105,7 @@ export class SsmParametersConstruct extends Construct {
     super(scope, id)
 
     const {
-      namePrefix: stackName,
+      namePrefix,
       parameters,
       readPolicyExportSuffix,
       readPolicyDescription = "Allows reading SSM parameters",
@@ -128,7 +128,7 @@ export class SsmParametersConstruct extends Construct {
       }
       seenIds.add(parameterId)
 
-      const parameterName = `${stackName}-${parameter.nameSuffix}`
+      const parameterName = `${namePrefix}-${parameter.nameSuffix}`
       if (seenNames.has(parameterName)) {
         throw new Error(`Duplicate parameter name detected: ${parameterName}.`)
       }
@@ -145,7 +145,7 @@ export class SsmParametersConstruct extends Construct {
       new CfnOutput(this, `${parameter.id}ParameterNameOutput`, {
         description: parameter.outputDescription ?? parameter.description,
         value: ssmParameter.parameterName,
-        exportName: `${stackName}-${parameter.outputExportSuffix ?? parameter.nameSuffix}`
+        exportName: `${namePrefix}-${parameter.outputExportSuffix ?? parameter.nameSuffix}`
       })
     }
 
@@ -163,7 +163,7 @@ export class SsmParametersConstruct extends Construct {
     new CfnOutput(this, "ReadParametersPolicyOutput", {
       description: readPolicyOutputDescription,
       value: readParametersPolicy.managedPolicyArn,
-      exportName: `${stackName}-${readPolicyExportSuffix}`
+      exportName: `${namePrefix}-${readPolicyExportSuffix}`
     })
 
     this.parameters = createdParameters