remove more gitsecret stuff

Author: anthony-nhs

.devcontainer/Dockerfile.bootstrap

@@ -52,15 +52,6 @@ RUN if [ "$TARGETARCH" = "arm64" ] || [ "$TARGETARCH" == "aarch64" ]; then \
     chmod +x /usr/bin/asdf && \
     rm -rf /tmp/asdf.tar.gz 
 
-# install gitsecrets
-RUN git clone https://github.com/awslabs/git-secrets.git /tmp/git-secrets && \
-    cd /tmp/git-secrets && \
-    make install && \
-    cd && \
-    rm -rf /tmp/git-secrets && \
-    mkdir -p /usr/share/secrets-scanner && \
-    chmod 755 /usr/share/secrets-scanner && \
-    curl -L https://raw.githubusercontent.com/NHSDigital/software-engineering-quality-framework/main/tools/nhsd-git-secrets/nhsd-rules-deny.txt -o /usr/share/secrets-scanner/nhsd-rules-deny.txt
 
 USER vscode
 
@@ -89,6 +80,3 @@ COPY .devcontainer/.tool-versions.bootstrap /home/vscode/.tool-versions
 # install python before poetry to ensure correct python version is used
 RUN asdf install python; \
     asdf install
-
-RUN git-secrets --register-aws --global && \
-  git-secrets --add-provider --global -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt

README.md

@@ -89,7 +89,6 @@ RUN if [ -n "${DOCKER_GID}" ]; then \
     },
     "updateRemoteUserUID": false,
   },
-  "postAttachCommand": "git-secrets --register-aws; git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt",
   "mounts": [
     "source=${env:HOME}${env:USERPROFILE}/.aws,target=/home/vscode/.aws,type=bind",
     "source=${env:HOME}${env:USERPROFILE}/.ssh,target=/home/vscode/.ssh,type=bind",

src/base/.devcontainer/scripts/lifecycle/post_create.sh

@@ -3,12 +3,3 @@
 set -euo pipefail
 
 echo "Running common post-create script"
-
-
-# Install git-secrets, register AWS patterns and NHS rules in an idempotent way
-if ! git config --get-all secrets.patterns | grep -Fq AKIA; then
-  git-secrets --register-aws
-fi
-if ! git config --get-all secrets.providers | grep -Fxq "cat /usr/share/secrets-scanner/nhsd-rules-deny.txt"; then
-  git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt
-fi