Document triangle attention kv_lengths fast path#287
Open
jomitchellnv wants to merge 2 commits into
Open
Conversation
Raise ValueError in the public wrapper when both `mask` and `kv_lengths` are supplied. They are mutually exclusive: `kv_lengths` selects the SM100f length fast path, while a dense `mask` uses the fallback path. The guard sits before the backend dispatch, so it surfaces the error early and needs no GPU. Add a GPU-free regression test. Signed-off-by: Jonathan Mitchell <jomitchell@nvidia.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jomitchellnv
force-pushed
the
jm/arbitrary-masks
branch
from
9cfca1a to
4c81937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #
Checklist
Please confirm the following before requesting review. PRs that do not meet these requirements cannot be merged. See CONTRIBUTING.md for the full contribution rules.
Contribution rules
pre-commitlocally (pip install pre-commit && pre-commit install).[WIP].Sign-off (DCO)
Per Signing Your Work, every commit in this PR must be signed off with
git commit -s(appendingSigned-off-by: Your Name <your@email.com>). PRs containing unsigned commits will not be accepted.git commit -s).