remove ASSERT_MESSAGE

Author: Mihail Slavchev

src/jni/NativeScriptAssert.h

@@ -18,7 +18,6 @@ namespace tns
 	#define DEBUG_WRITE_FORCE(fmt, args...) __android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", fmt, ##args)
 	#define DEBUG_WRITE_FATAL(fmt, args...) __android_log_print(ANDROID_LOG_FATAL, "TNS.Native", fmt, ##args)
 	#define ASSERT(cond) ((cond)?(void)0:__android_log_assert("##cond", "TNS.Native", ""))
-	#define ASSERT_MESSAGE(cond, fmt, args...) ((cond)?(void)0:__android_log_assert("##cond", "TNS.Native", fmt, ##args))
 	#define ASSERT_FAIL(fmt, args...) (__android_log_assert(fmt, "TNS.Native", fmt, ##args))
 }
 

src/jni/NativeScriptRuntime.cpp

@@ -739,7 +739,7 @@ void NativeScriptRuntime::DisableVerboseLoggingMethodCallback(const v8::Function
 void NativeScriptRuntime::ExitMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
 	auto msg = ConvertToString(args[0].As<String>());
-	ASSERT_MESSAGE(false, "%s", msg.c_str());
+	ASSERT_FAIL("%s", msg.c_str());
 	exit(-1);
 }
 

src/jni/ObjectManager.cpp

@@ -237,7 +237,7 @@ void ObjectManager::Link(const Local<Object>& object, uint32_t javaObjectID, jcl
 
 	auto jsInfoIdx = static_cast<int>(MetadataNodeKeys::JsInfo);
 	bool alreadyLinked = !object->GetInternalField(jsInfoIdx)->IsUndefined();
-	//ASSERT_MESSAGE(alreadyLinked, "object should not have been linked before");
+	//TODO: fail if alreadyLinked is true?
 
 	auto jsInfo = External::New(isolate, jsInstanceInfo);
 	object->SetInternalField(jsInfoIdx, jsInfo);