Skip to content

Commit b242d17

Browse files
author
Mihail Slavchev
committed
remove unused method parameters
1 parent bb8bebb commit b242d17

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

src/jni/NativeScriptRuntime.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void NativeScriptRuntime::Init(JavaVM *jvm, ObjectManager *objectManager)
4444
MAKE_CLASS_INSTANCE_OF_TYPE_STRONG = env.GetStaticMethodID(PlatformClass, "makeClassInstanceOfTypeStrong", "(Ljava/lang/String;)I");
4545
assert(MAKE_CLASS_INSTANCE_OF_TYPE_STRONG != nullptr);
4646

47-
CREATE_INSTANCE_METHOD_ID = env.GetStaticMethodID(PlatformClass, "createInstance", "(Ljava/lang/String;Ljava/lang/String;[Ljava/lang/Object;[Ljava/lang/String;II)Ljava/lang/Object;");
47+
CREATE_INSTANCE_METHOD_ID = env.GetStaticMethodID(PlatformClass, "createInstance", "([Ljava/lang/Object;[Ljava/lang/String;II)Ljava/lang/Object;");
4848
assert(CREATE_INSTANCE_METHOD_ID != nullptr);
4949

5050
CACHE_CONSTRUCTOR_METHOD_ID = env.GetStaticMethodID(PlatformClass, "cacheConstructor", "(Ljava/lang/String;Ljava/lang/String;[Ljava/lang/Object;[Ljava/lang/String;)I");
@@ -573,8 +573,6 @@ jobject NativeScriptRuntime::CreateJavaInstance(int objectID, const std::string&
573573

574574
jobject obj = env.CallStaticObjectMethod(PlatformClass,
575575
CREATE_INSTANCE_METHOD_ID,
576-
((jstring)javaName),
577-
((jstring)javaClassName),
578576
javaArgs,
579577
methodOverrides,
580578
(jint) objectID,

src/src/com/tns/Platform.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,8 @@ private static int cacheConstructor(String name, String className, Object[] args
205205
return ctorId;
206206
}
207207

208-
public static Object createInstance(String name, String className, Object[] args, String[] methodOverrides, int objectId, int constructorId) throws InstantiationException, IllegalAccessException, ClassNotFoundException, NoSuchMethodException, IllegalArgumentException, InvocationTargetException, IOException
208+
private static Object createInstance(Object[] args, String[] methodOverrides, int objectId, int constructorId) throws InstantiationException, IllegalAccessException, ClassNotFoundException, NoSuchMethodException, IllegalArgumentException, InvocationTargetException, IOException
209209
{
210-
if (IsLogEnabled)
211-
{
212-
Log.d(DEFAULT_LOG_TAG, "Creating instance for ctorId:" + constructorId + " className:" + className + " methodOverrides: " + Arrays.toString(methodOverrides));
213-
}
214-
215210
Constructor<?> ctor = ctorCache.get(constructorId);
216211
boolean success = MethodResolver.convertConstructorArgs(ctor, args);
217212

0 commit comments

Comments
 (0)