Skip to content

Commit dc7ad02

Browse files
committed
Fix incorrect block, thread and grid mixups
(Main mistake was that the order of parameters in AccessInstance was wrong, which lead me down a debugging session. Also for better naming changed global to local. As the respective ids are not the entirely global ids, but for example the local thread id in the current block, or the local block id in the current grid
1 parent 675c4bf commit dc7ad02

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

html/src/components/InspectDrawer.svelte

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,47 +42,47 @@
4242
</div>
4343
<div class="flex flex-row justify-around items-center flex-wrap my-2">
4444
<div class="section-container flex-1 max-w-xl !variant-glass-secondary mx-3">
45-
<div class="text-center font-mono">Grid Sizing:</div>
45+
<div class="text-center font-mono">Block Sizing:</div>
4646
<div class="flex flex-row justify-around">
4747
<div class="description-container mx-3">
4848
<div class="description-prefix">X:</div>
4949
<div class="description-content">
50-
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.x}
50+
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.x}
5151
</div>
5252
</div>
5353
<div class="description-container mx-3">
5454
<div class="description-prefix">Y:</div>
5555
<div class="description-content">
56-
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.y}
56+
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.y}
5757
</div>
5858
</div>
5959
<div class="description-container mx-3">
6060
<div class="description-prefix">Z:</div>
6161
<div class="description-content">
62-
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.z}
62+
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.z}
6363
</div>
6464
</div>
6565
</div>
6666
</div>
6767
<div class="section-container flex-1 max-w-xl !variant-glass-secondary mx-3">
68-
<div class="text-center font-mono">Block Sizing:</div>
68+
<div class="text-center font-mono">Grid Sizing:</div>
6969
<div class="flex flex-row justify-around">
7070
<div class="description-container mx-3">
7171
<div class="description-prefix">X:</div>
7272
<div class="description-content">
73-
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.x}
73+
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.x}
7474
</div>
7575
</div>
7676
<div class="description-container mx-3">
7777
<div class="description-prefix">Y:</div>
7878
<div class="description-content">
79-
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.y}
79+
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.y}
8080
</div>
8181
</div>
8282
<div class="description-container mx-3">
8383
<div class="description-prefix">Z:</div>
8484
<div class="description-content">
85-
{$drawerState.currentMemoryRegion.kernelSettings.BlockDimensions.z}
85+
{$drawerState.currentMemoryRegion.kernelSettings.GridDimensions.z}
8686
</div>
8787
</div>
8888
</div>

html/src/components/MemoryAccessInfo.svelte

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@
1717
<div class="description-container">
1818
<div class="description-prefix">X:</div>
1919
<div class="description-content">
20-
{access.blockID.x}
20+
{access.threadID.x}
2121
</div>
2222
</div>
2323
<div class="description-container">
2424
<div class="description-prefix">Y:</div>
2525
<div class="description-content">
26-
{access.blockID.y}
26+
{access.threadID.y}
2727
</div>
2828
</div>
2929
<div class="description-container">
3030
<div class="description-prefix">Z:</div>
3131
<div class="description-content">
32-
{access.blockID.z}
32+
{access.threadID.z}
3333
</div>
3434
</div>
3535
<div class="description-container pl-2">
36-
<div class="description-prefix">Global:</div>
36+
<div class="description-prefix">1D Local:</div>
3737
<div class="description-content">
3838
{access.threadIdGlobal}
3939
</div>
@@ -62,7 +62,7 @@
6262
</div>
6363
</div>
6464
<div class="description-container pl-2">
65-
<div class="description-prefix">Global:</div>
65+
<div class="description-prefix">1D Local:</div>
6666
<div class="description-content">
6767
{access.blockIdGlobal}
6868
</div>

html/src/lib/types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ export class AccessInstance {
4646

4747
constructor(
4848
address: string,
49-
threadId: number,
5049
blockId: number,
50+
threadId: number,
5151
isRead: boolean,
5252
kernelParameters: GenericInformation
5353
) {
@@ -58,9 +58,9 @@ export class AccessInstance {
5858
this.addressInteger = BigInt(this.address);
5959

6060
this.threadID = {
61-
x: this.threadIdGlobal % kernelParameters.GridDimensions.x,
62-
y: Math.floor(this.threadIdGlobal / kernelParameters.GridDimensions.x) % kernelParameters.GridDimensions.y,
63-
z: Math.floor(this.threadIdGlobal / (kernelParameters.GridDimensions.x * kernelParameters.GridDimensions.y))
61+
x: this.threadIdGlobal % kernelParameters.BlockDimensions.x,
62+
y: Math.floor(this.threadIdGlobal / kernelParameters.BlockDimensions.x) % kernelParameters.BlockDimensions.y,
63+
z: Math.floor(this.threadIdGlobal / (kernelParameters.BlockDimensions.x * kernelParameters.BlockDimensions.y))
6464
};
6565

6666
this.blockID = {

0 commit comments

Comments
 (0)