#1522: check if the material type already exists with test

Author: callmejim1226

src/backend/src/routes/projects.routes.ts

@@ -47,6 +47,8 @@ projectRouter.post(
 projectRouter.post('/:wbsNum/set-team', nonEmptyString(body('teamId')), validateInputs, ProjectsController.setProjectTeam);
 projectRouter.delete('/:wbsNum/delete', ProjectsController.deleteProject);
 projectRouter.post('/:wbsNum/favorite', ProjectsController.toggleFavorite);
+
+/**************** BOM Section ****************/
 projectRouter.post('/bom/material-type/create', nonEmptyString(body('name')), ProjectsController.createMaterialType);
 
 export default projectRouter;

src/backend/src/services/projects.services.ts

@@ -607,18 +607,27 @@ export default class ProjectsService {
    * Create a new material type
    * @param name the name of the new material type
    * @param submitter the user who is creating the material type
+   * @throws if the submitter is a leader or the material type with given name already exists
    */
   static async createMaterialType(name: string, submitter: User): Promise<Material_Type> {
     if (!isLeadership(submitter.role)) throw new AccessDeniedAdminOnlyException('create material type');
 
-    const materialType = await prisma.material_Type.create({
+    const materialType = await prisma.material_Type.findUnique({
+      where: {
+        name
+      }
+    });
+
+    if (!!materialType) throw new HttpException(400, `The following material type alraedy exists: ${name}`);
+
+    const newMaterialType = await prisma.material_Type.create({
       data: {
         name,
         dateCreated: new Date(),
         creatorId: submitter.userId
       }
     });
 
-    return materialType;
+    return newMaterialType;
   }
 }

src/backend/tests/projects.test.ts

@@ -260,11 +260,20 @@ describe('Projects', () => {
       );
     });
 
+    test('Create material type fails if the material type with the given name already exists'),
+      async () => {
+        vi.spyOn(prisma.material_Type, 'findUnique').mockResolvedValue(toolMaterial);
+
+        await expect(ProjectsService.createMaterialType('NERSoftwareTools', batman)).rejects.toThrow(
+          new HttpException(400, 'The following material type alraedy exists: NERSoftwareTools')
+        );
+      };
+
     test('Create material type works', async () => {
       vi.spyOn(prisma.material_Type, 'create').mockResolvedValue(toolMaterial);
 
-      const materialType = await ProjectsService.createMaterialType('Tools', batman);
-      expect(materialType.name).toBe('Tools');
+      const materialType = await ProjectsService.createMaterialType('NERSoftwareTools', batman);
+      expect(materialType.name).toBe('NERSoftwareTools');
       expect(prisma.material_Type.create).toBeCalledTimes(1);
     });
   });

src/backend/tests/test-data/projects.test-data.ts

@@ -104,7 +104,7 @@ export const sharedProject1: SharedProject = {
 };
 
 export const toolMaterial: PrismaMaterialType = {
-  name: 'Tools',
+  name: 'NERSoftwareTools',
   dateCreated: new Date(),
   creatorId: batman.userId
 };