Merge pull request #3468 from Northeastern-Electric-Racing/#3467-status-calculation-bug-fix

#3467 fixed date sorting on rr status

Author: walker-sean

src/frontend/src/hooks/finance.hooks.ts

@@ -47,6 +47,7 @@ import {
   ReimbursementStatusType
 } from 'shared';
 import { fullNamePipe } from '../utils/pipes';
+import { getCurrentReimbursementStatus } from '../utils/reimbursement-request.utils';
 
 export interface CreateReimbursementRequestPayload {
   vendorId: string;
@@ -405,7 +406,7 @@ export const useDownloadCSVFileOfReimbursementRequests = () => {
         .map(
           (rr) =>
             `${rr.saboId},${rr.identifier},${fullNamePipe(rr.recipient)},${rr.totalCost},${
-              rr.reimbursementStatuses[rr.reimbursementStatuses.length - 1].type
+              getCurrentReimbursementStatus(rr.reimbursementStatuses).type
             },${rr.account},${rr.accountCode.code},${rr.dateCreated},${rr.dateDelivered ?? ''},${
               rr.reimbursementStatuses.find((rs) => rs.type === ReimbursementStatusType.SABO_SUBMITTED)?.dateCreated ?? ''
             },${rr.vendor.name}`

src/frontend/src/pages/FinancePage/ReimbursementRequestDetailPage/ReimbursementRequestDetailsView.tsx

@@ -46,7 +46,8 @@ import {
   isReimbursementRequestSaboSubmitted,
   isReimbursementRequestDenied,
   isReimbursementRequestLeadershipApproved,
-  isReimbursementRequestPendingFinance
+  isReimbursementRequestPendingFinance,
+  getCurrentReimbursementStatus
 } from '../../../utils/reimbursement-request.utils';
 import { routes } from '../../../utils/routes';
 import AddSABONumberModal from './AddSABONumberModal';
@@ -469,15 +470,16 @@ const ReimbursementRequestDetailsView: React.FC<ReimbursementRequestDetailsViewP
     }
   ];
 
-  const sortedStatus = reimbursementRequest.reimbursementStatuses.sort((a) => a.dateCreated.getDate());
-  const statusTypes = sortedStatus.map((status) => status.type);
-  const recentStatus = statusTypes[statusTypes.length - 1];
   return (
     <PageLayout
       title={`Reimbursement Request #${reimbursementRequest.identifier} (${fullNamePipe(reimbursementRequest.recipient)})`}
       chips={
         <Box id="status" display="flex">
-          {statusTypes.length > 0 && <ReimbursementRequestStatusPill status={recentStatus} />}
+          {reimbursementRequest.reimbursementStatuses.length > 0 && (
+            <ReimbursementRequestStatusPill
+              status={getCurrentReimbursementStatus(reimbursementRequest.reimbursementStatuses).type}
+            />
+          )}
         </Box>
       }
       previousPages={[