Skip to content

Commit 18e5268

Browse files
committed
Revert "Changed the forms and updated editablelist"
This reverts commit e2b2c9a.
1 parent e2b2c9a commit 18e5268

4 files changed

Lines changed: 46 additions & 38 deletions

File tree

src/frontend/src/components/ReactHookEditableList.tsx

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,69 +1,69 @@
1-
import { Grid, Button, IconButton, TextField, Typography, Stack, InputLabel, Box } from '@mui/material';
1+
import { Grid, Button, IconButton, TextField, InputLabel, Box, Stack, Typography } from '@mui/material';
22
import DeleteIcon from '@mui/icons-material/Delete';
33
import { FieldArrayWithId, UseFieldArrayRemove, UseFormRegister, UseFieldArrayAppend } from 'react-hook-form';
4-
import { Title } from '@mui/icons-material';
54

65
interface ReactHookEditableListProps {
76
name: string;
87
ls: FieldArrayWithId[];
98
register: UseFormRegister<any>;
109
append: UseFieldArrayAppend<any, any>;
1110
remove: UseFieldArrayRemove;
11+
label: string;
1212
title: string;
1313
}
1414

15-
const ReactHookEditableList: React.FC<ReactHookEditableListProps> = ({ name, ls, title, register, append, remove }) => {
15+
const ReactHookEditableList: React.FC<ReactHookEditableListProps> = ({
16+
name,
17+
ls,
18+
register,
19+
append,
20+
remove,
21+
label = 'item'
22+
}) => {
1623
return (
1724
<>
18-
<Stack spacing={1}>
19-
<Stack direction={'row'} spacing={2}>
20-
<Typography variant="h5">{title}</Typography>
25+
<Box>
26+
<Stack direction="row" spacing={2}>
27+
<Typography variant="h5">{label + 's'}</Typography>
2128
<Button
2229
variant="contained"
2330
color="primary"
2431
onClick={() => append({ bulletId: -1, detail: '' })}
2532
sx={{ my: 2, width: 'max-content', textTransform: 'none' }}
2633
>
27-
+ Add {title}
34+
{'Add ' + label}
2835
</Button>
2936
</Stack>
3037
<Grid container spacing={2}>
31-
{
32-
//</Grid><Grid container sx={{ display: 'flex', flexDirection: 'row', flexWrap: 'wrap' }} spacing={2}>
33-
}
3438
{ls.map((_element, i) => {
3539
return (
36-
<>
37-
<Grid item sx={{ alignItems: 'center' }} xs={12} md={4}>
38-
<InputLabel>{title + ' ' + (i + 1)}</InputLabel>
39-
<Box sx={{ display: 'flex' }}>
40-
<TextField
41-
required
42-
multiline
43-
placeholder={'Enter ' + title + '...'}
44-
inputProps={{ style: { fontSize: 14 } }}
45-
minRows={2}
46-
autoComplete="off"
47-
sx={{ width: 12 / 12, padding: 0 }}
48-
{...register(`${name}.${i}.detail`)}
49-
/>
50-
<Stack spacing={0}>
51-
<IconButton
52-
type="button"
53-
onClick={() => remove(i)}
54-
sx={{ mx: 1, my: 0, color: 'red', borderRadius: '4px', outline: 'solid' }}
55-
>
56-
<DeleteIcon />
57-
</IconButton>
58-
<Box></Box>
59-
</Stack>
60-
</Box>
61-
</Grid>
62-
</>
40+
//Grid container with direction "row", and then each item inside is wrapped in a grid-element
41+
//xs argument: number out of 12, takes up that amount of space
42+
<Grid item sx={{ alignItems: 'center' }} xs={12} md={4}>
43+
<InputLabel>{label + ' ' + (i + 1)}</InputLabel>
44+
<Box sx={{ display: 'flex' }}>
45+
<TextField
46+
required
47+
multiline
48+
placeholder={'Enter a ' + label + '...'}
49+
inputProps={{ style: { fontSize: 14 } }}
50+
minRows={2}
51+
autoComplete="off"
52+
sx={{ width: 12 / 12, padding: 0 }}
53+
{...register(`${name}.${i}.detail`)}
54+
/>
55+
<Stack spacing={0}>
56+
<IconButton type="button" onClick={() => remove(i)} sx={{ mx: 1, my: 0 }}>
57+
<DeleteIcon />
58+
</IconButton>
59+
<Box></Box>
60+
</Stack>
61+
</Box>
62+
</Grid>
6363
);
6464
})}
6565
</Grid>
66-
</Stack>
66+
</Box>
6767
</>
6868
);
6969
};

src/frontend/src/pages/CreateWorkPackagePage/CreateWorkPackageFormView.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ const CreateWorkPackageFormView: React.FC<CreateWorkPackageFormViewProps> = ({
294294
ls={expectedActivities}
295295
append={appendExpectedActivity}
296296
remove={removeExpectedActivity}
297+
label="Expected Activity"
297298
title="Expected Activites"
298299
/>
299300
</FormControl>
@@ -306,6 +307,7 @@ const CreateWorkPackageFormView: React.FC<CreateWorkPackageFormViewProps> = ({
306307
ls={deliverables}
307308
append={appendDeliverable}
308309
remove={removeDeliverable}
310+
label="Deliverable"
309311
title="Deliverables"
310312
/>
311313
</FormControl>

src/frontend/src/pages/ProjectDetailPage/ProjectEdit/ProjectEditContainer.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ const ProjectEditContainer: React.FC<ProjectEditContainerProps> = ({ project, ex
219219
ls={goals}
220220
append={appendGoal}
221221
remove={removeGoal}
222+
label="Goal"
222223
title="Goals"
223224
/>
224225
<ReactHookEditableList
@@ -227,6 +228,7 @@ const ProjectEditContainer: React.FC<ProjectEditContainerProps> = ({ project, ex
227228
ls={features}
228229
append={appendFeature}
229230
remove={removeFeature}
231+
label="Feature"
230232
title="Features"
231233
/>
232234
<ReactHookEditableList
@@ -235,6 +237,7 @@ const ProjectEditContainer: React.FC<ProjectEditContainerProps> = ({ project, ex
235237
ls={constraints}
236238
append={appendConstraint}
237239
remove={removeConstraint}
240+
label="Constraint"
238241
title="Other Constraints"
239242
/>
240243
<ReactHookEditableList
@@ -243,6 +246,7 @@ const ProjectEditContainer: React.FC<ProjectEditContainerProps> = ({ project, ex
243246
ls={rules}
244247
append={appendRule}
245248
remove={removeRule}
249+
label="Rule"
246250
title="Rules"
247251
/>
248252
</Stack>

src/frontend/src/pages/WorkPackageDetailPage/WorkPackageEditContainer/WorkPackageEditContainer.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ const WorkPackageEditContainer: React.FC<WorkPackageEditContainerProps> = ({ wor
223223
ls={expectedActivities}
224224
append={appendExpectedActivity}
225225
remove={removeExpectedActivity}
226+
label="Expected Activity"
226227
title="Expected Activites"
227228
/>
228229
<ReactHookEditableList
@@ -231,6 +232,7 @@ const WorkPackageEditContainer: React.FC<WorkPackageEditContainerProps> = ({ wor
231232
ls={deliverables}
232233
append={appendDeliverable}
233234
remove={removeDeliverable}
235+
label="Deliverable"
234236
title="Deliverables"
235237
/>
236238
</Stack>

0 commit comments

Comments
 (0)