Added uniqueness check and tests

Author: jackturner106

src/backend/src/services/projects.services.ts

@@ -608,9 +608,9 @@ export default class ProjectsService {
   /**
    * Create an assembly
    * @param name The name of the assembly to be created
-   * @param pdmFileName The name of the file holding the assembly
    * @param userCreated The user creating the assembly
    * @param wbsElementId The
+   * @param pdmFileName optional - The name of the file holding the assembly
    * @returns the project that the user has favorited/unfavorited
    * @throws if the project wbs doesn't exist or is not corresponding to a project
    */
@@ -623,6 +623,14 @@ export default class ProjectsService {
     if (!isProject(wbsNumber)) throw new HttpException(400, `${wbsPipe(wbsNumber)} is not a valid project WBS #!`);
     const { carNumber, projectNumber, workPackageNumber } = wbsNumber;
 
+    const checkAssembly = await prisma.assembly.findUnique({
+      where: {
+        name
+      }
+    });
+
+    if (checkAssembly) throw new HttpException(400, `${name} already exists as an assembly!`);
+
     const project = await prisma.project.findFirst({
       where: {
         wbsElement: {

src/backend/tests/projects.test.ts

@@ -318,12 +318,32 @@ describe('Projects', () => {
       ).rejects.toThrow(new DeletedException('Project', prismaProject1.projectId));
     });
 
+    test('createAssembly fails if name is not unique', async () => {
+      vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue({ ...prismaAssembly1, name: 'a1' });
+
+      // no error, no return value
+      await expect(
+        async () =>
+          await ProjectsService.createAssembly(
+            'a1',
+            batman,
+            {
+              carNumber: 1,
+              projectNumber: 1,
+              workPackageNumber: 0
+            },
+            'file.txt'
+          )
+      ).rejects.toThrow(new HttpException(400, `a1 already exists as an assembly!`));
+    });
+
     test('createAssembly fails when no permissions', async () => {
       vi.spyOn(prisma.project, 'findFirst').mockResolvedValue({
         wbsElement: { ...prismaProject1.wbsElement, dateDeleted: '' },
         projectId: prismaProject1.projectId,
         teams: [{ prismaTeam1, leads: [], members: [] }]
       } as any);
+      vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue(null);
       await expect(
         async () =>
           await ProjectsService.createAssembly(
@@ -345,6 +365,7 @@ describe('Projects', () => {
         projectId: prismaProject1.projectId,
         teams: [{ prismaTeam1, leads: [], members: [] }]
       } as any);
+      vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue(null);
       await expect(
         async () =>
           await ProjectsService.createAssembly(
@@ -366,6 +387,7 @@ describe('Projects', () => {
         projectId: prismaProject1.projectId,
         teams: [{ prismaTeam1, leads: [], members: [] }]
       } as any);
+      vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue(null);
       vi.spyOn(prisma.assembly, 'create').mockResolvedValue(prismaAssembly1);
 
       // no error, no return value
@@ -385,6 +407,7 @@ describe('Projects', () => {
       mockGetHighestProjectNumber.mockResolvedValue(0);
       vi.spyOn(prisma.assembly, 'create').mockResolvedValue(prismaAssembly1);
       vi.spyOn(prisma.project, 'findFirst').mockResolvedValue(prismaProject1);
+      vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue(null);
 
       // no error, no return value
       await ProjectsService.createAssembly(