Skip to content

Commit 213b50c

Browse files
committed
#1593-Made a check for old reviewers before pinging
1 parent 529cfe2 commit 213b50c

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/backend/src/services/change-requests.services.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,12 +744,16 @@ export default class ChangeRequestsService {
744744

745745
if (foundCR.reviewerId) throw new HttpException(400, `Cannot request a review on an already reviewed change request`);
746746

747+
const oldRequestedReviewersIds = foundCR.requestedReviewers.map((reviewer) => reviewer.userId);
748+
747749
const reviewerIds = reviewers.map((reviewer) => {
748750
return {
749751
userId: reviewer.userId
750752
};
751753
});
752754

755+
const newReviewers = reviewers.filter((user) => !oldRequestedReviewersIds.includes(user.userId));
756+
753757
await prisma.change_Request.update({
754758
where: { crId },
755759
data: {
@@ -760,7 +764,7 @@ export default class ChangeRequestsService {
760764
});
761765

762766
// send slack message to CR reviewers
763-
reviewers.forEach(async (user) => {
767+
newReviewers.forEach(async (user) => {
764768
await sendSlackRequestedReviewNotification(user.userSettings!.slackId, changeRequestTransformer(foundCR));
765769
});
766770
}

0 commit comments

Comments
 (0)