#1417 - added tests, replaced get with post

Author: LOTaher

src/backend/src/controllers/work-packages.controllers.ts

@@ -29,13 +29,11 @@ export default class WorkPackagesController {
     }
   }
 
-  // Fetch the work packages for the specified WBS numbers
   static async getManyWorkPackages(req: Request, res: Response, next: NextFunction) {
     try {
-      const pastedWbs: string = req.body.wbsNums;
-      const wbsNums: WbsNumber[] = pastedWbs.split('\n').map((wbsNum) => validateWBS(wbsNum));
+      const wbsNums: WbsNumber[] = req.body.wbsNums.map((wbsNum: string) => validateWBS(wbsNum));
       const workPackages: WorkPackage[] = await WorkPackagesService.getManyWorkPackages(wbsNums);
-      res.send(200).json(workPackages);
+      res.status(200).json(workPackages);
     } catch (error: unknown) {
       next(error);
     }

src/backend/src/routes/work-packages.routes.ts

@@ -7,7 +7,7 @@ const workPackagesRouter = express.Router();
 
 workPackagesRouter.get('/', WorkPackagesController.getAllWorkPackages);
 workPackagesRouter.get('/:wbsNum', WorkPackagesController.getSingleWorkPackage);
-workPackagesRouter.get('/get-many', WorkPackagesController.getManyWorkPackages);
+workPackagesRouter.post('/get-many', WorkPackagesController.getManyWorkPackages);
 workPackagesRouter.post(
   '/create',
   intMinZero(body('crId')),

src/backend/src/services/work-packages.services.ts

@@ -140,7 +140,7 @@ export default class WorkPackagesService {
       ...workPackageQueryArgs
     });
 
-    if (!workPackages) {
+    if (!workPackages || workPackages.length !== wbsNums.length) {
       throw new NotFoundException('Work Package', wbsNums.map((wbsNum) => wbsPipe(wbsNum)).join(', '));
     }
 

src/backend/tests/work-packages.test.ts

@@ -292,6 +292,49 @@ describe('Work Packages', () => {
     });
   });
 
+  describe('getManyWorkPackages', () => {
+    test('should retrieve work packages for valid WBS numbers', async () => {
+      const wbsNums = [
+        { carNumber: 1, projectNumber: 1, workPackageNumber: 1 },
+        { carNumber: 1, projectNumber: 1, workPackageNumber: 1 }
+      ];
+
+      vi.spyOn(prisma.work_Package, 'findMany').mockResolvedValue([prismaWorkPackage1, prismaWorkPackage1]);
+
+      const result = await WorkPackageService.getManyWorkPackages(wbsNums);
+
+      expect(result).toStrictEqual([sharedWorkPackage, sharedWorkPackage]);
+    });
+
+    test('should throw an error for a project WBS number', async () => {
+      const wbsNums = [{ carNumber: 1, projectNumber: 1, workPackageNumber: 0 }];
+
+      await expect(async () => await WorkPackageService.getManyWorkPackages(wbsNums)).rejects.toThrow(
+        new HttpException(404, 'WBS Number 1.1.0 is a project WBS#, not a Work Package WBS#')
+      );
+    });
+
+    test('should throw an error for non-existent WBS numbers', async () => {
+      const wbsNums = [{ carNumber: 9, projectNumber: 9, workPackageNumber: 9 }];
+
+      vi.spyOn(prisma.work_Package, 'findMany').mockResolvedValue([]);
+
+      await expect(async () => await WorkPackageService.getManyWorkPackages(wbsNums)).rejects.toThrow(
+        new NotFoundException('Work Package', '9.9.9')
+      );
+    });
+
+    test('should retrieve an empty array for an empty WBS numbers array', async () => {
+      const wbsNums: WbsNumber[] = [];
+
+      vi.spyOn(prisma.work_Package, 'findMany').mockResolvedValue([]);
+
+      const result = await WorkPackageService.getManyWorkPackages(wbsNums);
+
+      expect(result).toStrictEqual([]);
+    });
+  });
+
   describe('slackMessageUpcomingDeadlines', () => {
     beforeEach(() => {
       vi.spyOn(slackUtils, 'sendSlackUpcomingDeadlineNotification').mockImplementation(async () => {});