Skip to content

Commit 2be2809

Browse files
committed
Merge branch 'multitenancy' into develop
2 parents 4da848e + 2ff0333 commit 2be2809

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

src/backend/src/prisma-query-args/design-reviews.query-args.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const getDesignReviewQueryArgs = (organizationId: string) =>
1414
deniedMembers: getUserQueryArgs(organizationId),
1515
attendees: getUserQueryArgs(organizationId),
1616
userDeleted: getUserQueryArgs(organizationId),
17-
wbsElement: true
17+
wbsElement: true,
18+
notificationSlackThreads: true,
1819
}
1920
});

src/backend/src/services/change-requests.services.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,18 @@ export default class ChangeRequestsService {
141141
accepted,
142142
dateReviewed: new Date()
143143
},
144-
include: { activationChangeRequest: true, wbsElement: { include: { workPackage: true } } }
144+
include: {
145+
activationChangeRequest: true,
146+
notificationSlackThreads: true,
147+
wbsElement: { include: { workPackage: true } }
148+
}
145149
});
146150

147151
// send the creator of the cr a slack notification that their cr was reviewed
148152
await sendCRSubmitterReviewedNotification(foundCR);
149153

150154
// send a reply to a CR's notifications of its updated status
151-
const relevantThreads = await prisma.message_Info.findMany({ where: { changeRequestId: foundCR.crId } });
152-
await sendSlackCRStatusToThread(relevantThreads, foundCR.crId, accepted);
155+
await sendSlackCRStatusToThread(updated.notificationSlackThreads, foundCR.crId, accepted);
153156

154157
return updated.crId;
155158
}

src/backend/src/services/design-reviews.services.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,6 @@ export default class DesignReviewsService {
306306
// actually try to update the design review
307307
const updatedDesignReview = await prisma.design_Review.update({
308308
where: { designReviewId },
309-
...getDesignReviewQueryArgs(organizationId),
310309
data: {
311310
designReviewId,
312311
dateScheduled,
@@ -327,12 +326,12 @@ export default class DesignReviewsService {
327326
attendees: {
328327
set: updatedAttendees
329328
}
330-
}
329+
},
330+
...getDesignReviewQueryArgs(organizationId)
331331
});
332332

333333
if (status === Design_Review_Status.SCHEDULED) {
334-
const relevantThreads = await prisma.message_Info.findMany({ where: {} });
335-
await sendDRScheduledSlackNotif(relevantThreads, updatedDesignReview);
334+
await sendDRScheduledSlackNotif(updatedDesignReview.notificationSlackThreads, updatedDesignReview);
336335
}
337336

338337
return designReviewTransformer(updatedDesignReview);
@@ -397,8 +396,7 @@ export default class DesignReviewsService {
397396
}
398397
});
399398

400-
const relevantThreads = await prisma.message_Info.findMany({ where: { designReviewId: designReview.designReviewId } });
401-
await sendDRUserConfirmationToThread(relevantThreads, submitter);
399+
await sendDRUserConfirmationToThread(updatedDesignReview.notificationSlackThreads, submitter);
402400

403401
// If all required attendees have confirmed their schedule, mark design review as confirmed
404402
if (areUsersinList(designReview.requiredMembers, updatedDesignReview.confirmedMembers)) {

0 commit comments

Comments
 (0)