Skip to content

Commit 3179c0b

Browse files
committed
merge-conflicts
1 parent b81611f commit 3179c0b

4 files changed

Lines changed: 31 additions & 17 deletions

File tree

src/backend/src/prisma/seed.ts

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,14 @@ const performSeed: () => Promise<void> = async () => {
467467
explain: 'need this to initialize work packages'
468468
}
469469
],
470-
[]
470+
[
471+
{
472+
budgetImpact: 0,
473+
description: 'Initializing seed data',
474+
timelineImpact: 0,
475+
scopeImpact: 'no scope impact'
476+
}
477+
]
471478
);
472479

473480
const changeRequestWP1Id = changeRequestWP1.crId;
@@ -500,7 +507,14 @@ const performSeed: () => Promise<void> = async () => {
500507
explain: 'need this to initialize work packages'
501508
}
502509
],
503-
[]
510+
[
511+
{
512+
budgetImpact: 0,
513+
description: 'Initializing seed data',
514+
timelineImpact: 0,
515+
scopeImpact: 'no scope impact'
516+
}
517+
]
504518
);
505519

506520
const changeRequestWP5Id = changeRequestWP5.crId;

src/frontend/src/components/ChangeRequestDropdown.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,9 @@ interface ChangeRequestDropdownProps {
3434
control: Control<any, any>;
3535
name: string;
3636
errors: FieldErrors<ChangeRequest>;
37-
changeHeight?: number;
3837
}
3938

40-
const ChangeRequestDropdown = ({ control, name, errors, changeHeight = 1 }: ChangeRequestDropdownProps) => {
39+
const ChangeRequestDropdown = ({ control, name, errors }: ChangeRequestDropdownProps) => {
4140
const user = useCurrentUser();
4241
const { isLoading, data: changeRequests } = useAllChangeRequests();
4342
if (isLoading || !changeRequests) return <LoadingIndicator />;
@@ -69,7 +68,7 @@ const ChangeRequestDropdown = ({ control, name, errors, changeHeight = 1 }: Chan
6968
onChange={(event: SelectChangeEvent<number>) => onChange(event.target.value)}
7069
size={'small'}
7170
placeholder={'Change Request Id'}
72-
sx={{ textAlign: 'left', height: changeHeight }}
71+
sx={{ height: 56, width: '100%', textAlign: 'left' }}
7372
error={!!errors.crId}
7473
MenuProps={{
7574
anchorOrigin: {

src/frontend/src/pages/WorkPackageForm/WorkPackageForm.tsx

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,18 @@ const WorkPackageForm: React.FC<WorkPackageFormProps> = ({ wbsNum, mutateAsync,
3838
wp.wbsNum.workPackageNumber === wbsNum.workPackageNumber
3939
);
4040

41-
const defaultValues: WorkPackageFormViewPayload | undefined = createForm
42-
? undefined
43-
: {
44-
...workPackage!,
45-
workPackageId: workPackage!.id,
46-
crId: workPackage!.changes[0].changeRequestId.toString(),
47-
stage: workPackage!.stage ?? 'NONE',
48-
blockedBy: workPackage!.blockedBy.map(wbsPipe),
49-
expectedActivities: bulletsToObject(workPackage!.expectedActivities),
50-
deliverables: bulletsToObject(workPackage!.deliverables)
51-
};
41+
const defaultValues: WorkPackageFormViewPayload | undefined =
42+
!createForm && workPackage
43+
? {
44+
...workPackage,
45+
workPackageId: workPackage.id,
46+
crId: workPackage!.changes[0].changeRequestId.toString(),
47+
stage: workPackage!.stage ?? 'NONE',
48+
blockedBy: workPackage!.blockedBy.map(wbsPipe),
49+
expectedActivities: bulletsToObject(workPackage!.expectedActivities),
50+
deliverables: bulletsToObject(workPackage!.deliverables)
51+
}
52+
: undefined;
5253

5354
const blockedByToAutocompleteOption = (workPackage: WorkPackage) => {
5455
return { id: wbsPipe(workPackage.wbsNum), label: `${wbsPipe(workPackage.wbsNum)} - ${workPackage.name}` };

src/frontend/src/pages/WorkPackageForm/WorkPackageFormDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const WorkPackageFormDetails: React.FC<Props> = ({
8484
</FormControl>
8585
</Grid>
8686
<Grid item xs={12} md={3}>
87-
<ChangeRequestDropdown control={control} name="crId" errors={errors} changeHeight={56} />
87+
<ChangeRequestDropdown control={control} name="crId" errors={errors} />
8888
</Grid>
8989
<Grid item xs={12} md={3}>
9090
<StageSelect />

0 commit comments

Comments
 (0)