Merge pull request #1336 from Northeastern-Electric-Racing/HotFix

hotfix

Author: RChandler234

src/backend/src/services/change-requests.services.ts

@@ -118,16 +118,12 @@ export default class ChangeRequestsService {
         await prisma.project.update({
           where: { projectId: foundCR.wbsElement.project.projectId },
           data: {
-            budget: newBudget,
-            wbsElement: {
-              update: {
-                changes: {
-                  create: change
-                }
-              }
-            }
+            budget: newBudget
           }
         });
+
+        //Make the associated budget change if there was a change
+        if (change) await prisma.change.create({ data: change });
       } else if (foundCR.wbsElement.workPackage) {
         // get the project for the work package
         const wpProj = await prisma.project.findUnique({

src/backend/tests/change-requests.test.ts

@@ -210,24 +210,6 @@ describe('Change Requests', () => {
       expect(prisma.change_Request.findUnique).toHaveBeenCalledTimes(1);
       expect(prisma.proposed_Solution.findUnique).toHaveBeenCalledTimes(1);
       expect(prisma.user_Settings.findUnique).toHaveBeenCalledTimes(1);
-      expect(prisma.project.update).toHaveBeenCalledWith({
-        data: {
-          budget: 1003,
-          wbsElement: {
-            update: {
-              changes: {
-                create: {
-                  changeRequestId: 2,
-                  detail: 'Changed Budget from "3" to "1003"',
-                  implementerId: 2,
-                  wbsElementId: 65
-                }
-              }
-            }
-          }
-        },
-        where: { projectId: 2 }
-      });
       expect(prisma.change_Request.update).toHaveBeenCalledTimes(1);
     });