Merge pull request #1698 from Northeastern-Electric-Racing/#1593-Backend-RequestReviewerPing

#1593-Made a check for old reviewers before pinging

Author: RChandler234

src/backend/src/services/change-requests.services.ts

@@ -744,12 +744,16 @@ export default class ChangeRequestsService {
 
     if (foundCR.reviewerId) throw new HttpException(400, `Cannot request a review on an already reviewed change request`);
 
+    const oldRequestedReviewersIds = foundCR.requestedReviewers.map((reviewer) => reviewer.userId);
+
     const reviewerIds = reviewers.map((reviewer) => {
       return {
         userId: reviewer.userId
       };
     });
 
+    const newReviewers = reviewers.filter((user) => !oldRequestedReviewersIds.includes(user.userId));
+
     await prisma.change_Request.update({
       where: { crId },
       data: {
@@ -760,7 +764,7 @@ export default class ChangeRequestsService {
     });
 
     // send slack message to CR reviewers
-    reviewers.forEach(async (user) => {
+    newReviewers.forEach(async (user) => {
       await sendSlackRequestedReviewNotification(user.userSettings!.slackId, changeRequestTransformer(foundCR));
     });
   }

src/backend/tests/change-requests.test.ts

@@ -457,9 +457,10 @@ describe('Change Requests', () => {
       expect(prisma.change_Request.findUnique).toHaveBeenCalledTimes(1);
     });
 
+    const changeRequest = { ...prismaChangeRequest1, requestedReviewers: [] };
     test('Change request successfully assigned reviewers', async () => {
       vi.spyOn(prisma.user, 'findMany').mockResolvedValue([batmanWithUserSettings]);
-      vi.spyOn(prisma.change_Request, 'findUnique').mockResolvedValue(prismaChangeRequest1);
+      vi.spyOn(prisma.change_Request, 'findUnique').mockResolvedValue(changeRequest);
       vi.spyOn(prisma.change_Request, 'update').mockResolvedValue(prismaChangeRequest1);
 
       await ChangeRequestsService.requestCRReview(batman, [1], 1);