File tree Expand file tree Collapse file tree
src/frontend/src/pages/ChangeRequestDetailPage Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -147,7 +147,6 @@ const ChangeRequestDetailsView: React.FC<ChangeRequestDetailsProps> = ({
147147 changes = { changeRequest . implementedChanges || [ ] }
148148 overallDateImplemented = { changeRequest . dateImplemented }
149149 />
150-
151150 { reviewModalShow && (
152151 < ReviewChangeRequest modalShow = { reviewModalShow } handleClose = { handleReviewClose } cr = { changeRequest } />
153152 ) }
Original file line number Diff line number Diff line change @@ -27,7 +27,7 @@ const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps>
2727 if ( isError ) return < ErrorPage error = { error } message = { error . message } /> ;
2828
2929 // the CRs submitted or reviewed by the submitter of this CR
30- const crFromSameUser = changeRequests ?. filter (
30+ const crsFromSubmitter = changeRequests ?. filter (
3131 ( cr ) =>
3232 ( cr . submitter . userId === changeRequest . submitter . userId || cr . reviewer ?. userId === changeRequest . submitter . userId ) &&
3333 cr . crId !== changeRequest . crId
@@ -42,9 +42,7 @@ const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps>
4242 { tab === value ? < ExpandMore sx = { { pl : 0.5 } } /> : < ExpandLess sx = { { pl : 0.5 } } /> }
4343 </ Typography >
4444 }
45- onClick = { ( ) => {
46- tab === value && setTab ( 0 ) ;
47- } }
45+ onClick = { ( ) => tab === value && setTab ( 0 ) }
4846 />
4947 ) ;
5048
@@ -111,7 +109,7 @@ const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps>
111109 >
112110 { displayTab ( 1 , `Other CR's from ${ changeRequest . submitter . firstName } ${ changeRequest . submitter . lastName } ` ) }
113111 </ Tabs >
114- < Collapse in = { tab !== 0 } > { tab === 1 && displayCRCards ( crFromSameUser || [ ] ) } </ Collapse >
112+ < Collapse in = { tab !== 0 } > { tab === 1 && displayCRCards ( crsFromSubmitter || [ ] ) } </ Collapse >
115113 </ Box >
116114 ) ;
117115} ;
You can’t perform that action at this time.
0 commit comments