Skip to content

Commit 4072655

Browse files
committed
#1525 - fix tests
1 parent 9386a1d commit 4072655

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/backend/src/services/projects.services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ export default class ProjectsService {
655655
if (!project) throw new NotFoundException('Project', wbsPipe(wbsNumber));
656656

657657
if (assemblyId) {
658-
const assembly = prisma.assembly.findFirst({ where: { assemblyId } });
658+
const assembly = await prisma.assembly.findFirst({ where: { assemblyId } });
659659
if (!assembly) throw new NotFoundException('Assembly', assemblyId);
660660
}
661661

src/backend/tests/projects.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
prismaUnit
1515
} from './test-data/projects.test-data';
1616
import { prismaChangeRequest1 } from './test-data/change-requests.test-data';
17-
import { prismaTeam1 } from './test-data/teams.test-data';
17+
import { primsaTeam2, prismaTeam1 } from './test-data/teams.test-data';
1818
import * as projectTransformer from '../src/transformers/projects.transformer';
1919
import ProjectsService from '../src/services/projects.services';
2020
import {
@@ -456,7 +456,7 @@ describe('Projects', () => {
456456
});
457457
test('createMaterial fails when assembly is not found', async () => {
458458
vi.spyOn(prisma.project, 'findFirst').mockResolvedValue(prismaProject1);
459-
vi.spyOn(prisma.assembly, 'findFirst').mockImplementation(() => undefined);
459+
vi.spyOn(prisma.assembly, 'findFirst').mockResolvedValue(null);
460460

461461
await expect(() =>
462462
ProjectsService.createMaterial(
@@ -557,7 +557,8 @@ describe('Projects', () => {
557557
).rejects.toThrow(new NotFoundException('Unit', 'FT'));
558558
});
559559
test('createMaterial fails if the creator does not have perms', async () => {
560-
vi.spyOn(prisma.project, 'findFirst').mockResolvedValue({ prismaProject1, teams: [] });
560+
const customProject = { ...prismaProject1, teams: [primsaTeam2] };
561+
vi.spyOn(prisma.project, 'findFirst').mockResolvedValue(customProject);
561562
vi.spyOn(prisma.assembly, 'findFirst').mockResolvedValue(prismaAssembly1);
562563
vi.spyOn(prisma.material_Type, 'findFirst').mockResolvedValue(prismaMaterialType);
563564
vi.spyOn(prisma.manufacturer, 'findFirst').mockResolvedValue(prismaManufacturer2);

0 commit comments

Comments
 (0)