#2136 - zoomlink optional broken, wrong date range, prefill time range

Author: RChandler234

src/frontend/src/pages/CalendarPage/DesignReviewDetailPage/DesignReviewDetailPage.tsx

@@ -50,8 +50,8 @@ const DesignReviewDetailPage: React.FC<DesignReviewDetailPageProps> = ({ designR
     new Date(designReview.dateScheduled.getTime() - designReview.dateScheduled.getTimezoneOffset() * -60000)
   );
   const [showDeleteModal, setShowDeleteModal] = useState(false);
-  const [startTime, setStateTime] = useState(0);
-  const [endTime, setEndTime] = useState(1);
+  const [startTime, setStateTime] = useState(designReview.meetingTimes[0] % 12);
+  const [endTime, setEndTime] = useState((designReview.meetingTimes[designReview.meetingTimes.length - 1] % 12) + 1);
 
   const { isLoading: allUsersIsLoading, isError: allUsersIsError, error: allUsersError, data: allUsers } = useAllUsers();
   const {

src/frontend/src/pages/CalendarPage/DesignReviewDetailPage/FinalizeDesignReviewDetailsModal.tsx

@@ -17,7 +17,7 @@ const schema = yup.object().shape({
   zoomLink: yup
     .string()
     .optional()
-    .test('zoom-link', 'Must be a valid zoom link', (value) => value!.includes('zoom.us/')),
+    .test('zoom-link', 'Must be a valid zoom link', (value) => (value ? value.includes('zoom.us/') : true)),
   location: yup.string().optional(),
   docTemplateLink: yup.string().required('Question Doc is Required')
 });

src/frontend/src/utils/pipes.ts

@@ -132,9 +132,9 @@ export const designReviewNamePipe = (designReview: DesignReview) => {
 };
 
 export const dateRangePipe = (startDate: Date, endDate: Date) => {
-  return `${(startDate.getMonth() + 1).toString()}/${endDate.getDate().toString()} - ${(
+  return `${(startDate.getMonth() + 1).toString()}/${startDate.getDate().toString()} - ${(
     endDate.getMonth() + 1
-  ).toString()}/${startDate.getDate().toString()}`;
+  ).toString()}/${endDate.getDate().toString()}`;
 };
 
 export const undefinedPipe = (element: any) => {