Merge pull request #1359 from Northeastern-Electric-Racing/#1253-ping-task-asignees

#1253 Ping Task Assignees on Slack

Author: RChandler234

src/backend/src/services/tasks.services.ts

@@ -6,7 +6,7 @@ import teamQueryArgs from '../prisma-query-args/teams.query-args';
 import prisma from '../prisma/prisma';
 import taskTransformer from '../transformers/tasks.transformer';
 import { NotFoundException, AccessDeniedException, HttpException, DeletedException } from '../utils/errors.utils';
-import { hasPermissionToEditTask } from '../utils/tasks.utils';
+import { hasPermissionToEditTask, sendSlackTaskAssignedNotificationToUsers } from '../utils/tasks.utils';
 import { areUsersPartOfTeams, isUserOnTeam } from '../utils/teams.utils';
 import { getUsers } from '../utils/users.utils';
 import { wbsNumOf } from '../utils/utils';
@@ -79,7 +79,11 @@ export default class TasksService {
       ...taskQueryArgs
     });
 
-    return taskTransformer(createdTask);
+    const newTask = taskTransformer(createdTask);
+
+    sendSlackTaskAssignedNotificationToUsers(newTask, assignees);
+
+    return newTask;
   }
 
   /**
@@ -152,12 +156,16 @@ export default class TasksService {
     const originalTask = await prisma.task.findUnique({
       where: { taskId },
       include: {
-        wbsElement: { include: { project: { ...projectQueryArgs } } }
+        wbsElement: { include: { project: { ...projectQueryArgs } } },
+        assignees: true
       }
     });
     if (!originalTask) throw new NotFoundException('Task', taskId);
     if (originalTask.dateDeleted) throw new DeletedException('Task', taskId);
 
+    const originalAssigneeIds = originalTask.assignees.map((assignee) => assignee.userId);
+    const newAssigneeIds = assignees.filter((userId) => !originalAssigneeIds.includes(userId));
+
     const hasPermission = await hasPermissionToEditTask(user, taskId);
     if (!hasPermission)
       throw new AccessDeniedException(
@@ -183,17 +191,21 @@ export default class TasksService {
       };
     });
 
-    const updatedTask = await prisma.task.update({
-      where: { taskId },
-      data: {
-        assignees: {
-          set: transformedAssigneeUsers
-        }
-      },
-      ...taskQueryArgs
-    });
-
-    return taskTransformer(updatedTask);
+    const updatedTask = taskTransformer(
+      await prisma.task.update({
+        where: { taskId },
+        data: {
+          assignees: {
+            set: transformedAssigneeUsers
+          }
+        },
+        ...taskQueryArgs
+      })
+    );
+
+    await sendSlackTaskAssignedNotificationToUsers(updatedTask, newAssigneeIds);
+
+    return updatedTask;
   }
 
   /**

src/backend/src/utils/slack.utils.ts

@@ -1,6 +1,7 @@
-import { ChangeRequest, daysBetween, User, wbsPipe, WorkPackage } from 'shared';
+import { ChangeRequest, daysBetween, Task, User, wbsPipe, WorkPackage } from 'shared';
 import { sendMessage } from '../integrations/slack';
 import { getUserSlackId } from './users.utils';
+import prisma from '../prisma/prisma';
 
 // build the "due" string for the upcoming deadlines slack message
 const buildDueString = (daysUntilDeadline: number): string => {
@@ -51,3 +52,18 @@ export const sendSlackRequestedReviewNotification = async (slackId: string, chan
   const fullMsg = `Your review has been requested on CR #${changeRequest.crId}: ${changeRequestLink}.`;
   await sendMessage(slackId, fullMsg);
 };
+
+/**
+ * Send Task assigned notification to assignee on Slack
+ * @param slackId the slack id of the assignee
+ * @param task the task they were assigned to
+ */
+export const sendSlackTaskAssignedNotification = async (slackId: string, task: Task): Promise<void> => {
+  if (process.env.NODE_ENV !== 'production') return; // don't send msgs unless in prod
+
+  const project = await prisma.wBS_Element.findUnique({ where: { wbsNumber: task.wbsNum } });
+  const msg = `You have been assigned to a task: ${task.title} on project ${wbsPipe(task.wbsNum)} - ${project?.name}`;
+  const link = `https://finishlinebyner.com/projects/${wbsPipe(task.wbsNum)}/tasks`;
+  const linkButtonText = 'View Task';
+  await sendMessage(slackId, msg, link, linkButtonText);
+};

src/backend/src/utils/tasks.utils.ts

@@ -1,6 +1,7 @@
 import { Task_Priority, Task_Status, User } from '@prisma/client';
-import { isHead, TaskPriority, TaskStatus } from 'shared';
+import { isHead, Task, TaskPriority, TaskStatus } from 'shared';
 import prisma from '../prisma/prisma';
+import { sendSlackTaskAssignedNotification } from './slack.utils';
 
 export const convertTaskPriority = (priority: Task_Priority): TaskPriority =>
   ({
@@ -103,3 +104,17 @@ export const hasPermissionToEditTask = async (user: User, taskId: string): Promi
 
   return false;
 };
+
+/**
+ * Sends a task assigned notification to the specified users on Slack
+ * @param task the task the users are assigned to
+ * @param assigneeIds the user ids of the users assigned to the task
+ */
+export const sendSlackTaskAssignedNotificationToUsers = async (task: Task, assigneeIds: number[]) => {
+  const assigneeSettings = await prisma.user_Settings.findMany({ where: { userId: { in: assigneeIds } } });
+  assigneeSettings.forEach(async (settings) => {
+    if (settings.slackId) {
+      await sendSlackTaskAssignedNotification(settings.slackId, task);
+    }
+  });
+};

src/backend/tests/tasks.test.ts

@@ -16,7 +16,16 @@ import {
   taskSaveTheDayPrisma,
   taskSaveTheDayShared
 } from './test-data/tasks.test-data';
-import { aquaman, batman, greenlantern, superman, theVisitor, wonderwoman } from './test-data/users.test-data';
+import {
+  aquaman,
+  batman,
+  batmanSettings,
+  greenlantern,
+  superman,
+  supermanSettings,
+  theVisitor,
+  wonderwoman
+} from './test-data/users.test-data';
 import { prismaWbsElement1 } from './test-data/wbs-element.test-data';
 import { prismaProject1 } from './test-data/projects.test-data';
 import { justiceLeague, prismaTeam1 } from './test-data/teams.test-data';
@@ -129,6 +138,7 @@ describe('Tasks', () => {
       vi.spyOn(teamUtils, 'areUsersPartOfTeams').mockReturnValue(true);
       vi.spyOn(prisma.task, 'create').mockResolvedValue(taskSaveTheDayPrisma);
       vi.spyOn(prisma.user, 'findMany').mockResolvedValue([batman, wonderwoman]);
+      vi.spyOn(prisma.user_Settings, 'findMany').mockResolvedValue([batmanSettings, supermanSettings]);
 
       const task = await TasksService.createTask(batman, mockWBSNum, 'hellow world', '', mockDate, 'HIGH', 'DONE', [
         batman.userId,
@@ -243,6 +253,7 @@ describe('Tasks', () => {
       vi.spyOn(taskTransformer, 'default').mockReturnValue(taskSaveTheDayInProgressShared);
       vi.spyOn(userUtils, 'getUsers').mockResolvedValue([batman, wonderwoman]);
       vi.spyOn(teamUtils, 'areUsersPartOfTeams').mockReturnValue(true);
+      vi.spyOn(prisma.user_Settings, 'findMany').mockResolvedValue([batmanSettings, supermanSettings]);
 
       const taskId = '1';
       const userIds = [