Skip to content

Commit 5987f7f

Browse files
committed
#954: fixed bug with stage when editing workpackage
1 parent b98a441 commit 5987f7f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/backend/src/services/work-packages.services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ export default class WorkPackagesService {
362362
let changes = [];
363363
// get the changes or undefined for each of the fields
364364
const nameChangeJson = createChange('name', originalWorkPackage.wbsElement.name, name, crId, userId, wbsElementId!);
365-
const stageChangeJson = createChange('stage', originalWorkPackage.stage, stage ?? 'None', crId, userId, wbsElementId!);
365+
const stageChangeJson = createChange('stage', originalWorkPackage.stage, stage, crId, userId, wbsElementId!);
366366
const startDateChangeJson = createChange(
367367
'start date',
368368
originalWorkPackage.startDate.toDateString(),

src/backend/src/utils/changes.utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const createChange = (
3939
implementerId: number,
4040
wbsElementId: number
4141
): ChangeCreateArgs | undefined => {
42-
if (oldValue == null) {
42+
if (oldValue == null && newValue !== null) {
4343
return {
4444
changeRequestId: crId,
4545
implementerId,

0 commit comments

Comments
 (0)